auth: do not allow update root role

2015-06-23 20:12:18 -07:00
parent c0b5cc6c52
commit 030d1bbf2d
1 changed files with 3 additions and 0 deletions
--- a/etcdserver/auth/auth.go
+++ b/etcdserver/auth/auth.go
@ -338,6 +338,9 @@ func (s *Store) DeleteRole(name string) error {
 }

 func (s *Store) UpdateRole(role Role) (Role, error) {
+	if role.Role == RootRoleName {
+		return Role{}, authErr(http.StatusForbidden, "Cannot modify role %s: is root role.", role.Role)
+	}
 	old, err := s.GetRole(role.Role)
 	if err != nil {
 		if e, ok := err.(*etcderr.Error); ok {