mirrors/etcd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use contain to make tests clearer and more resilient to changes

Browse Source 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
This commit is contained in:
Marek Siarkowicz
2023-10-12 11:44:31 +02:00
parent 6f63f4b676
commit 05cc60a539
1 changed files with 20 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

88
tests/framework/e2e/cluster_test.go
View File

@ -17,138 +17,86 @@ package e2e
import (
"testing"
"github.com/google/go-cmp/cmp"
"github.com/stretchr/testify/assert"
)
func TestEtcdServerProcessConfig(t *testing.T) {
tcs := []struct {
name string
config *EtcdProcessClusterConfig
expectArgs []string
expectArgsNotContain []string
expectArgsContain []string
}{
{
name: "Default",
config: NewConfig(),
expectArgs: []string{
"--name=TestEtcdServerProcessConfigDefault-test-0",
expectArgsContain: []string{
"--listen-client-urls=http://localhost:0",
"--advertise-client-urls=http://localhost:0",
"--listen-peer-urls=http://localhost:1",
"--initial-advertise-peer-urls=http://localhost:1",
"--initial-cluster-token=new",
"--data-dir=/tmp/fake/member-0",
"--snapshot-count=10000",
},
},
{
name: "SnapshotCount",
config: NewConfig(WithSnapshotCount(42)),
expectArgs: []string{
"--name=TestEtcdServerProcessConfigSnapshotCount-test-0",
"--listen-client-urls=http://localhost:0",
"--advertise-client-urls=http://localhost:0",
"--listen-peer-urls=http://localhost:1",
"--initial-advertise-peer-urls=http://localhost:1",
"--initial-cluster-token=new",
"--data-dir=/tmp/fake/member-0",
expectArgsContain: []string{
"--snapshot-count=42",
},
},
{
name: "SnapshotCatchUpEntries",
config: NewConfig(WithSnapshotCatchUpEntries(12)),
expectArgs: []string{
"--name=TestEtcdServerProcessConfigSnapshotCatchUpEntries-test-0",
"--listen-client-urls=http://localhost:0",
"--advertise-client-urls=http://localhost:0",
"--listen-peer-urls=http://localhost:1",
"--initial-advertise-peer-urls=http://localhost:1",
"--initial-cluster-token=new",
"--data-dir=/tmp/fake/member-0",
"--snapshot-count=10000",
expectArgsContain: []string{
"--experimental-snapshot-catchup-entries=12",
},
},
{
name: "QuotaBackendBytes",
config: NewConfig(WithQuotaBackendBytes(123)),
expectArgs: []string{
"--name=TestEtcdServerProcessConfigQuotaBackendBytes-test-0",
"--listen-client-urls=http://localhost:0",
"--advertise-client-urls=http://localhost:0",
"--listen-peer-urls=http://localhost:1",
"--initial-advertise-peer-urls=http://localhost:1",
"--initial-cluster-token=new",
"--data-dir=/tmp/fake/member-0",
"--snapshot-count=10000",
expectArgsContain: []string{
"--quota-backend-bytes=123",
},
},
{
name: "CorruptCheck",
config: NewConfig(WithInitialCorruptCheck(true)),
expectArgs: []string{
"--name=TestEtcdServerProcessConfigCorruptCheck-test-0",
"--listen-client-urls=http://localhost:0",
"--advertise-client-urls=http://localhost:0",
"--listen-peer-urls=http://localhost:1",
"--initial-advertise-peer-urls=http://localhost:1",
"--initial-cluster-token=new",
"--data-dir=/tmp/fake/member-0",
"--snapshot-count=10000",
expectArgsContain: []string{
"--experimental-initial-corrupt-check",
},
},
{
name: "StrictReconfigCheck",
config: NewConfig(WithStrictReconfigCheck(false)),
expectArgs: []string{
"--name=TestEtcdServerProcessConfigStrictReconfigCheck-test-0",
"--listen-client-urls=http://localhost:0",
"--advertise-client-urls=http://localhost:0",
"--listen-peer-urls=http://localhost:1",
"--initial-advertise-peer-urls=http://localhost:1",
"--initial-cluster-token=new",
"--data-dir=/tmp/fake/member-0",
"--snapshot-count=10000",
expectArgsContain: []string{
"--strict-reconfig-check=false",
},
},
{
name: "CatchUpEntries",
config: NewConfig(WithSnapshotCatchUpEntries(100)),
expectArgs: []string{
"--name=TestEtcdServerProcessConfigCatchUpEntries-test-0",
"--listen-client-urls=http://localhost:0",
"--advertise-client-urls=http://localhost:0",
"--listen-peer-urls=http://localhost:1",
"--initial-advertise-peer-urls=http://localhost:1",
"--initial-cluster-token=new",
"--data-dir=/tmp/fake/member-0",
"--snapshot-count=10000",
expectArgsContain: []string{
"--experimental-snapshot-catchup-entries=100",
},
},
{
name: "CatchUpEntriesLastVersion",
config: NewConfig(WithSnapshotCatchUpEntries(100), WithVersion(LastVersion)),
expectArgs: []string{
"--name=TestEtcdServerProcessConfigCatchUpEntriesLastVersion-test-0",
"--listen-client-urls=http://localhost:0",
"--advertise-client-urls=http://localhost:0",
"--listen-peer-urls=http://localhost:1",
"--initial-advertise-peer-urls=http://localhost:1",
"--initial-cluster-token=new",
"--data-dir=/tmp/fake/member-0",
"--snapshot-count=10000",
expectArgsNotContain: []string{
"--experimental-snapshot-catchup-entries=100",
},
},
}
for _, tc := range tcs {
t.Run(tc.name, func(t *testing.T) {
tc.config.BaseDataDirPath = "/tmp/fake"
if diff := cmp.Diff(tc.config.EtcdServerProcessConfig(t, 0).Args, tc.expectArgs); diff != "" {
t.Errorf("diff: %s", diff)
args := tc.config.EtcdServerProcessConfig(t, 0).Args
if len(tc.expectArgsContain) != 0 {
assert.Subset(t, args, tc.expectArgsContain)
}
if len(tc.expectArgsNotContain) != 0 {
assert.NotSubset(t, args, tc.expectArgsNotContain)
}
})
}