mirrors/etcd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

integration: fix a data race about err

Browse Source 
don't share `err` between goroutines
This commit is contained in:
Zeming YU
2019-08-06 13:31:32 -07:00
parent 44a00a33ef
commit 181419256d
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
clientv3/integration/metrics_test.go
View File

@ -41,12 +41,13 @@ func TestV3ClientMetrics(t *testing.T) {
var ( var (
addr = "localhost:27989" addr = "localhost:27989"
ln net.Listener ln net.Listener
err error
) )
// listen for all Prometheus metrics // listen for all Prometheus metrics
donec := make(chan struct{}) donec := make(chan struct{})
go func() { go func() {
var err error
defer close(donec) defer close(donec)
srv := &http.Server{Handler: promhttp.Handler()} srv := &http.Server{Handler: promhttp.Handler()}
@ -87,7 +88,7 @@ func TestV3ClientMetrics(t *testing.T) {
pBefore := sumCountersForMetricAndLabels(t, url, "grpc_client_started_total", "Put", "unary") pBefore := sumCountersForMetricAndLabels(t, url, "grpc_client_started_total", "Put", "unary")
_, err = cli.Put(context.Background(), "foo", "bar") _, err := cli.Put(context.Background(), "foo", "bar")
if err != nil { if err != nil {
t.Errorf("Error putting value in key store") t.Errorf("Error putting value in key store")
} }