mirrors/etcd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pkg/netutil: fix DropPort and RecoverPort in linux

Browse Source 
The iptables commands in DropPort do not work because setting
destination-port flag without specifying the protocol is invalid.
This commit is contained in:
Yicheng Qin
2015-03-31 10:35:51 -07:00
parent 2990c29a71
commit 24f9ba8ee8
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/netutil/isolate_linux.go
View File

@ -19,24 +19,24 @@ import (
"os/exec" "os/exec"
) )
// DropPort drops all network packets that are received from the given port and sent to the given port. // DropPort drops all tcp packets that are received from the given port and sent to the given port.
func DropPort(port int) error { func DropPort(port int) error {
cmdStr := fmt.Sprintf("sudo iptables -A OUTPUT --destination-port %d -j DROP", port) cmdStr := fmt.Sprintf("sudo iptables -A OUTPUT -p tcp --destination-port %d -j DROP", port)
if _, err := exec.Command("/bin/sh", "-c", cmdStr).Output(); err != nil { if _, err := exec.Command("/bin/sh", "-c", cmdStr).Output(); err != nil {
return err return err
} }
cmdStr = fmt.Sprintf("sudo iptables -A INPUT --destination-port %d -j DROP", port) cmdStr = fmt.Sprintf("sudo iptables -A INPUT -p tcp --destination-port %d -j DROP", port)
_, err := exec.Command("/bin/sh", "-c", cmdStr).Output() _, err := exec.Command("/bin/sh", "-c", cmdStr).Output()
return err return err
} }
// RecoverPort stops dropping network packets at given port. // RecoverPort stops dropping tcp packets at given port.
func RecoverPort(port int) error { func RecoverPort(port int) error {
cmdStr := fmt.Sprintf("sudo iptables -D OUTPUT --destination-port %d -j DROP", port) cmdStr := fmt.Sprintf("sudo iptables -D OUTPUT -p tcp --destination-port %d -j DROP", port)
if _, err := exec.Command("/bin/sh", "-c", cmdStr).Output(); err != nil { if _, err := exec.Command("/bin/sh", "-c", cmdStr).Output(); err != nil {
return err return err
} }
cmdStr = fmt.Sprintf("sudo iptables -D INPUT --destination-port %d -j DROP", port) cmdStr = fmt.Sprintf("sudo iptables -D INPUT -p tcp --destination-port %d -j DROP", port)
_, err := exec.Command("/bin/sh", "-c", cmdStr).Output() _, err := exec.Command("/bin/sh", "-c", cmdStr).Output()
return err return err
} }