mirrors/etcd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

*: add MemberAddAsLearner to clientv3 Cluster API

Browse Source 
Made changes to Clientv3 Cluster API:

- Added MemberAddAsLearner.
- Reverted changes to MemberAdd - removed input parameter isLearner.
This commit is contained in:
Jingyi Hu
2019-05-14 16:56:44 -07:00
parent 1e38de5b9d
commit 2b76200f70
7 changed files with 71 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
clientv3/integration/cluster_test.go
View File

@ -53,7 +53,7 @@ func TestMemberAdd(t *testing.T) {
capi := clus.RandClient()
urls := []string{"http://127.0.0.1:1234"}
resp, err := capi.MemberAdd(context.Background(), urls, false)
resp, err := capi.MemberAdd(context.Background(), urls)
if err != nil {
t.Fatalf("failed to add member %v", err)
}
@ -175,7 +175,7 @@ func TestMemberAddUpdateWrongURLs(t *testing.T) {
{"localhost:1234"},
}
for i := range tt {
_, err := capi.MemberAdd(context.Background(), tt[i], false)
_, err := capi.MemberAdd(context.Background(), tt[i])
if err == nil {
t.Errorf("#%d: MemberAdd err = nil, but error", i)
}
@ -195,14 +195,13 @@ func TestMemberAddForLearner(t *testing.T) {
capi := clus.RandClient()
urls := []string{"http://127.0.0.1:1234"}
isLearner := true
resp, err := capi.MemberAdd(context.Background(), urls, isLearner)
resp, err := capi.MemberAddAsLearner(context.Background(), urls)
if err != nil {
t.Fatalf("failed to add member %v", err)
}
if resp.Member.IsLearner != isLearner {
t.Errorf("Added a member with IsLearner = %v, got %v", isLearner, resp.Member.IsLearner)
if !resp.Member.IsLearner {
t.Errorf("Added a member as learner, got resp.Member.IsLearner = %v", resp.Member.IsLearner)
}
numOfLearners, err := getNumberOfLearners(clus)