diff --git a/Documentation/contributor-guide/community-membership.md b/Documentation/contributor-guide/community-membership.md index 2951d205c..15d5615a0 100644 --- a/Documentation/contributor-guide/community-membership.md +++ b/Documentation/contributor-guide/community-membership.md @@ -24,7 +24,7 @@ below. ## Member -Members are continuously active contributors in the community. They can have +Members are continuously active contributors to the community. They can have issues and PRs assigned to them. Members are expected to remain active contributors to the community. @@ -41,7 +41,7 @@ contributors to the community. - Subscribed to [etcd-dev@googlegroups.com](https://groups.google.com/g/etcd-dev) - Have read the [contributor guide] - Sponsored by two active maintainers or reviewers. - - Sponsors must be from multiple member companies to demonstrate integration across community. + - Sponsors must be from multiple member companies to demonstrate integration across the community. - With no objections from other maintainers - Open a [membership nomination] issue against the `kubernetes/org` repo - Ensure your sponsors are @mentioned on the issue @@ -54,11 +54,11 @@ contributors to the community. - Responsive to issues and PRs assigned to them - Granted "triage access" to etcd project - Active owner of code they have contributed (unless ownership is explicitly transferred) - - Code is well tested + - Code is well-tested - Tests consistently pass - Addresses bugs or issues discovered after code is accepted -**Note:** members who frequently contribute code are expected to proactively +**Note:** Members who frequently contribute code are expected to proactively perform code reviews and work towards becoming a *reviewer*. ## Reviewers @@ -78,7 +78,7 @@ maintainership. - Reviewed or contributed at least 20 substantial PRs to the codebase. - Knowledgeable about the codebase. - Sponsored by two active maintainers. - - Sponsors must be from multiple member companies to demonstrate integration across community. + - Sponsors must be from multiple member companies to demonstrate integration across the community. - With no objections from other maintainers - Reviewers can be removed by a supermajority of the maintainers or can resign by notifying the maintainers. @@ -96,8 +96,8 @@ maintainership. ## Maintainers -Maintainers are first and foremost contributors that have shown they -are committed to the long term success of a project. Maintainership is about building +Maintainers are first and foremost contributors who have shown they +are committed to the long-term success of a project. Maintainership is about building trust with the current maintainers and being a person that they can depend on to make decisions in the best interest of the project in a consistent manner. @@ -109,20 +109,20 @@ depend on to make decisions in the best interest of the project in a consistent - Deep understanding of the technical domain of the project - Sustained contributions to design and direction by doing all of: - Authoring and reviewing proposals - - Initiating, contributing and resolving discussions (emails, GitHub issues, meetings) - - Identifying subtle or complex issues in designs and implementation PRs -- Directly contributed to the project through implementation and / or review + - Initiating, contributing, and resolving discussions (emails, GitHub issues, meetings) + - Identifying subtle or complex issues in the designs and implementation of PRs +- Directly contributed to the project through implementation and/or review - Sponsored by two active maintainers and elected by supermajority - - Sponsors must be from multiple member companies to demonstrate integration across community. + - Sponsors must be from multiple member companies to demonstrate integration across the community. - To become a maintainer send an email with your candidacy to etcd-maintainers-private@googlegroups.com - - Ensure your sponsors are @mentioned on the email + - Ensure your sponsors are @mentioned in the email - Include a list of contributions representative of your work on the project. - - Existing maintainers vote will privately and respond to the email with either acceptance or with feedback for suggested improvement. + - Existing maintainers vote will privately and respond to the email with either acceptance or feedback for suggested improvement. - With your membership approved you are expected to: - Open a PR and add an entry to the [OWNERS] file - Subscribe to etcd-maintainers@googlegroups.com and etcd-maintainers-private@googlegroups.com - - Request to join to [etcd-maintainer teams of etcd organization of GitHub](https://github.com/orgs/etcd-io/teams/maintainers-etcd) - - Request to join to the private slack channel for etcd maintainers on [kubernetes slack](http://slack.kubernetes.io/) + - Request to join [etcd-maintainer teams of etcd organization of GitHub](https://github.com/orgs/etcd-io/teams/maintainers-etcd) + - Request to join the private slack channel for etcd maintainers on [kubernetes slack](http://slack.kubernetes.io/) - Request access to etcd-development GCP project where we publish releases - Request access to passwords shared between maintainers @@ -133,26 +133,26 @@ depend on to make decisions in the best interest of the project in a consistent - Define milestones and releases - Mentor and guide reviewers, and contributors to the project. - Participate when called upon in the [security disclosure and release process] -- Ensure continued health of the project +- Ensure the continued health of the project - Adequate test coverage to confidently release - Tests are passing reliably (i.e. not flaky) and are fixed when they fail -- Ensure a healthy process for discussion and decision making is in place. +- Ensure a healthy process for discussion and decision-making is in place. - Work with other maintainers to maintain the project's overall health and success holistically ### Retiring Life priorities, interests, and passions can change. Maintainers can retire and move to [emeritus maintainers]. If a maintainer needs to step down, they should -inform other maintainers, if possible, help find someone to pick up the related -work. At the very least, ensure the related work can be continued. Afterward -they can remove themselves from list of existing maintainers. +inform other maintainers and, if possible, help find someone to pick up the related +work. At the very least, ensure the related work can be continued. Afterward, +they can remove themselves from the list of existing maintainers. -If a maintainer has not been performing their duties for period of 12 months, -they can be removed by other maintainers. In that case inactive maintainer will -be first notified via an email. If situation doesn't improve, they will be +If a maintainer has not been performing their duties for 12 months, +they can be removed by other maintainers. In that case, the inactive maintainer will +be first notified via an email. If the situation doesn't improve, they will be removed. If an emeritus maintainer wants to regain an active role, they can do so by renewing their contributions. Active maintainers should welcome such a move. -Retiring of other maintainers or regaining the status should require approval +Retiring other maintainers or regaining the status should require the approval of at least two active maintainers. ## Acknowledgements @@ -166,3 +166,4 @@ Contributor roles and responsibilities were written based on [Kubernetes communi [emeritus maintainers]: /README.md#etcd-emeritus-maintainers [security disclosure and release process]: /security/README.md [two-factor authentication]: https://docs.github.com/en/authentication/securing-your-account-with-two-factor-authentication-2fa/about-two-factor-authentication +