75 Commits

Author SHA1 Message Date
06edd83d28 server: remove ExperimentalMaxLearners
ExperimentalMaxLearners was introduced in v3.6, so there's no need to
worry about deprecating, it can be migrated straight into a FeatureGate.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-03-07 22:22:43 -08:00
5fa8c1f6b8 Migrate --experimental-set-member-localaddr to using feature flag
Signed-off-by: Chun-Hung Tseng <henrytseng@google.com>
Co-authored-by: Benjamin Wang <benjamin.wang@broadcom.com>
2025-02-13 16:02:10 +00:00
9c30af2ff5 Standardize help deprecated messages
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-12 16:29:40 -08:00
eea79ca9a5 Properly deprecate ExperimentalInitialCorruptCheck
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-12 16:14:34 -08:00
fe81901c74 Properly deprecate ExperimentalStopGRPCServiceOnDefrag
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-12 16:03:07 -08:00
e37615a483 Properly deprecate ExperimentalTxnModeWriteWithSharedBuffer
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-12 15:57:57 -08:00
5802231328 migrate experimental-snapshot-catchup-entries flag to snapshot-catchup-entries
Signed-off-by: Ajay Sundar Karuppasamy <ajaysundar@google.com>
2025-02-11 19:17:17 +00:00
a9b8cba602 Migrate experimental distributed tracing flags to non-experimental flags
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2025-02-11 15:29:16 +00:00
a3a467bf39 migrate experimental-peer-skip-client-san-verification flag to peer-skip-client-san-verification
Co-authored-by: wodeyoulai <106662970@qq.com>

Signed-off-by: Siyuan Zhang <sizhang@google.com>
2025-02-07 10:35:03 -08:00
a090db470b Merge pull request #19356 from siyuanfoundation/lease-checkpoint
migrate experimental-enable-lease-checkpoint and experimental-enable-lease-checkpoint-persist flag to feature gate.
2025-02-07 15:14:40 +00:00
2cd8fcce5d migrate experimental-enable-lease-checkpoint and experimental-enable-lease-checkpoint-persist flag to feature gate.
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2025-02-06 14:31:00 -08:00
e5b39f85a4 migrate experimental-compaction-sleep-interval flag to compaction-sleep-interval
Signed-off-by: Ajay Sundar Karuppasamy <ajaysundar@google.com>
2025-02-06 18:54:32 +00:00
80a8a82bbd migrate experimental-downgrade-check-time to downgrade-check-time
Signed-off-by: Ajay Sundar Karuppasamy <ajaysundar@google.com>
2025-02-06 00:05:04 +00:00
0795f6b957 migrate experimental-memory-mlock flag to memory-mlock
Signed-off-by: Jiayin Mao <jiayin.mao@datadoghq.com>
2025-02-01 22:57:54 +00:00
27d9978c8e migrate to use max-learners flag
Signed-off-by: Gang Li <gangligit@gmail.com>
2025-01-28 17:23:51 -08:00
267020e940 migrate to use bootstrap-defrag-threshold-megabytes flag
Signed-off-by: Gang Li <gangligit@gmail.com>
2025-01-24 13:21:48 -08:00
7f1d3b017b migrate to use warning-apply-duration flag
Signed-off-by: Gang Li <gangligit@gmail.com>
2025-01-24 10:23:29 -08:00
b16b8dc6f3 migrate flag experimental-watch-progress-notify-interval to use watch-progress-notify-interval (#19248)
migrate flag experimental-watch-progress-notify-interval to use watch-progress-notify-interval

Signed-off-by: Gang Li <gangligit@gmail.com>
2025-01-23 21:08:30 +00:00
33d65fc90b TestConfigFileDeprecatedOptions
Signed-off-by: Gang Li <gangligit@gmail.com>
2025-01-14 16:26:50 -08:00
f4e7157ff1 migrate to use corrupt-check-time flag
Signed-off-by: Gang Li <gangligit@gmail.com>

add entry for --corrupt-check-time in help.go

Signed-off-by: Gang Li <gangligit@gmail.com>

remove a space

Signed-off-by: Gang Li <gangligit@gmail.com>

fix format

Signed-off-by: Gang Li <gangligit@gmail.com>

fix cluster.go

Signed-off-by: Gang Li <gangligit@gmail.com>

Add test in e2e for experimental corrupt check time flag

Signed-off-by: Gang Li <gangligit@gmail.com>

fix comment

Signed-off-by: Gang Li <gangligit@gmail.com>

fix comment

Signed-off-by: Gang Li <gangligit@gmail.com>
2025-01-13 11:58:40 -08:00
c73b3d1e8f migrate experimental-txn-mode-write-with-shared-buffer flag to feature gate.
Signed-off-by: ishan16696 <ishan.tyagi@sap.com>
2024-12-21 23:46:11 +05:30
85363bda32 migrate experimental-compact-hash-check-enabled to feature gate.
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2024-12-17 09:44:53 -08:00
4bdf0d233e Mark --max-snapshots as deprecated in 3.6 and will be decommissioned in 3.7
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-12-10 12:15:53 +00:00
f54c8f55d3 Deprecate --v2-deprecation and schedule to remove it in 3.8
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-12-04 14:44:18 +00:00
8bc42d9075 Mark --snapshot-count as deprecated in v3.6 and will be decommissioned in v3.7
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-12-03 15:02:17 +00:00
a966c07165 migrate experimental-initial-corrupt-check flag to feature gate.
Signed-off-by: Lan Liang <gcslyp@gmail.com>
2024-08-22 14:42:18 +00:00
bd228cf6d1 migrate experimental-stop-grpc-service-on-defrag flag to feature gate.
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2024-08-05 13:46:51 -07:00
7b355141d9 Add "server-feature-gates" flag.
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2024-07-18 13:20:30 -07:00
a657f069a1 fix(server/embed): enforce non-empty client TLS if scheme is https/unixs
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2024-06-17 18:21:38 +08:00
acc9d7c9fe Support multiple values for allowed client and peer TLS identities
Signed-off-by: lhy1024 <admin@liudos.us>
2024-06-06 21:25:17 +08:00
4c77726914 Implement flag --experimental-set-member-localaddr
Which sets the LocalAddr to an IP address from --initial-advertise-peer-urls.

Also adds e2e test that requires this flag to succeed.

Co-authored-by: HighPon <s.shiraki.business@gmail.com>
Signed-off-by: Edwin Xie <edwin.xie@broadcom.com>
2024-05-24 18:17:37 +00:00
a2bf8d7e80 server/config: address golangci var-naming issues
Addresses issues in V2 Deprecation constant names.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-04-22 17:12:15 -07:00
cf66d0f64f etcdserver: updated pre-vote flag description
To better communicate what the pre-vote phase in Raft is.

Signed-off-by: Fube <fubeitch@gmail.com>
2024-04-12 17:14:19 -04:00
fc8568a435 nit: Fix trailing whitespace in etcdmain/help.go
Signed-off-by: Edwin Xie <edwin.xie@broadcom.com>
2024-04-01 22:25:05 +00:00
ea035471ce online defrag notifies gRPC health server to expose NOT_SERVING status
Signed-off-by: Chao Chen <chaochn@amazon.com>
2023-10-25 08:58:33 -07:00
e31de5e3c1 Revert "etcd server shouldn't wait for the ready notification infinitely on startup"
This reverts commit 1713dc67b5.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-10-03 21:37:18 +02:00
63e614fb0b Add unit test for CLI flags and missing flags
Signed-off-by: John Riendeau <riendeau@us.ibm.com>
2023-08-23 08:33:39 -05:00
6760dc9572 remove repetitive the
Signed-off-by: cui fliter <imcusg@gmail.com>
2023-07-13 17:01:01 +08:00
798d2b7923 add compact hash check to help
Signed-off-by: scuzk373x@gmai.com <zhuanwajiang@pinduoduo.com>
2023-06-08 14:29:57 +08:00
32c83becf5 fix review: Updated description of --initial-cluster-state flag
Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
2023-04-22 23:16:33 +02:00
bf12179a5a server: Add --listen-client-http-urls flag to allow running grpc server separate from http server
Difference in load configuration for watch delay tests show how huge the
impact is. Even with random write scheduler grpc under http
server can only handle 500 KB with 2 seconds delay. On the other hand,
separate grpc server easily hits 10, 100 or even 1000 MB within 100 miliseconds.

Priority write scheduler that was used in most previous releases
is far worse than random one.

Tests configured to only 5 MB to avoid flakes and taking too long to fill
etcd.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-03-30 09:49:45 +02:00
275e10bcf7 Return default snapshot count to 10,000.
The huge (100k+) value was justified when storev2 was being dumped completely with every snapshot.

With storev2 being decomissioned we can checkpoint more frequently for faster recovery.

Signed-off-by: James Blair <mail@jamesblair.net>
2023-03-06 20:21:03 +13:00
588b98d085 Add TLSv1.3 support.
Added optional TLS min/max protocol version and command line switches to set
versions for the etcd server.

If max version is not explicitly set by the user, let Go select the max
version which is currently TLSv1.3. Previously max version was set to TLSv1.2.

Signed-off-by: Tero Saarni <tero.saarni@est.tech>
2023-01-30 16:16:53 +02:00
2c46b2b299 externalize snapshot catchup entries to etcd flag
Signed-off-by: Chao Chen <chaochn@amazon.com>
2023-01-04 19:01:07 -08:00
9e1abbab6e Fix goimports in all existing files. Execution of ./scripts/fix.sh
Signed-off-by: Piotr Tabor <ptab@google.com>
2022-12-29 09:41:31 +01:00
ebfcaaed34 test: fix the test failures in e2e/warning_logging_test.go
1. Fixed the test failures which are caused by recent test framework rafactoring;
2. renamed the file to promote_experimental_flag_test.go.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-11-19 01:51:06 +08:00
7e8ebf7727 server: added duplicate warning-unary-request-duration flag
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in v3.7.

fixes https://github.com/etcd-io/etcd/issues/13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
2022-11-18 18:06:00 +08:00
1a6fe4dbc6 update the comment for MaxConcurrentStreams to clearly state it's the max value for each client.
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-07-07 04:51:20 +08:00
053ba95ed5 set max concurrent streams to the http2 server
The default max stream is 250 in http2. When there are more then
250 streams, the client side may be blocked until some previous
streams are released. So we need to support configuring a larger
`MaxConcurrentStreams`.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-07-06 03:43:46 +08:00
6220174687 support custom grpc.MaxConcurrentStreams
There is no update on the original PR (see below) for more then 2
weeks. So Benjamin(@ahrtr) continues to work on the PR. The first
step is to rebase the PR, because there are lots of conflicts with
the main branch.

The change to go.mod and go.sum reverted, because they are not needed.
The e2e test cases are also reverted, because they are not correct.

```
https://github.com/etcd-io/etcd/pull/14081
```

Signed-off-by: nic-chen <chenjunxu6@gmail.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-07-06 03:43:46 +08:00