3b37afec7b
Don't follow redirects when checking peer urls.
...
It's possible that etcd server may run into SSRF situation when adding a new member. If users provide a malicious peer URL, the existing etcd members may be redirected to other unexpected internal URL when getting the new member's version.
Signed-off-by: James Blair <mail@jamesblair.net >
2023-11-21 10:25:20 +13:00
33b526f58d
dependency: bump golang.org/x/net from 0.17.0 to 0.18.0
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com >
2023-11-16 11:03:00 +01:00
4907fedbc3
dependency: bump golang.org/x/crypto from 0.14.0 to 0.15.0
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com >
2023-11-16 10:50:17 +01:00
7586098f78
dependency: bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.18.0 to 2.18.1
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com >
2023-11-16 10:44:50 +01:00
3897103b77
etcdserver: add metric counters for livez/readyz health checks.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2023-11-14 09:26:00 -08:00
acd5724689
dependency: bump go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.19.0 to 1.20.0
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com >
2023-11-13 12:18:48 +01:00
8066e8116b
dependency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.45.0 to 0.46.0
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com >
2023-11-13 11:53:02 +01:00
8da89177a9
etcdctl,etcdutl,pkg,server,tests,tools: bump github.com/spf13/cobra from 1.7.0 to 1.8.0
...
- https://github.com/etcd-io/etcd/pull/16878/
Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com >
2023-11-09 11:02:36 -06:00
ed30fb1226
*: bump golang.org/x/sys from 0.13.0 to 0.14.0
...
- https://github.com/etcd-io/etcd/pull/16875
Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com >
2023-11-09 11:02:36 -06:00
2b7e1c6f82
fix scripts
...
Signed-off-by: Tessa Pham <hpham111@bloomberg.net >
2023-11-08 00:27:13 -06:00
d2ada92830
etcdctl,etcdutl,server,tests: update golang.org/x/time to v0.4.0
...
- https://github.com/etcd-io/etcd/pull/16880
Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com >
2023-11-07 11:01:51 -06:00
8264b4e9ae
clientv3,server,tests: bump dependencies identified by dependabot
...
Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com >
2023-11-05 09:27:37 -06:00
8a6c1335e2
v3rpc: run health notifier to listen on online defrag state change
...
Signed-off-by: Chao Chen <chaochn@amazon.com >
2023-10-28 17:49:24 -07:00
1101655b9f
bump bbolt to 1.3.8 for main branch
...
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2023-10-26 16:34:15 +01:00
ea035471ce
online defrag notifies gRPC health server to expose NOT_SERVING status
...
Signed-off-by: Chao Chen <chaochn@amazon.com >
2023-10-25 08:58:33 -07:00
34382006db
test: implement method ForgetLeader for struct nodeRecorder
...
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2023-10-24 10:19:13 +01:00
ae60b5567a
bump raft to latest commit
...
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2023-10-24 10:17:57 +01:00
d2af596a98
depdendency: bump github.com/prometheus/common from 0.44.0 to 0.45.0.
...
Signed-off-by: James Blair <mail@jamesblair.net >
2023-10-24 17:44:01 +13:00
e6e740fb80
depdendency: bump google.golang.org/grpc from 1.58.3 to 1.59.0.
...
Signed-off-by: James Blair <mail@jamesblair.net >
2023-10-24 17:39:39 +13:00
1324f03254
add existing http health check handler e2e test
...
Signed-off-by: Chao Chen <chaochn@amazon.com >
2023-10-18 12:42:23 -07:00
11edde9204
Merge pull request #16622 from fuweid/fix-unparam-lint
...
*: enable and fix unparam lint
2023-10-18 09:21:22 +02:00
f96000e15d
*: cleanup main_test.go
...
The #15544 has removed the `build_cov` build. And after go1.20, we use
`-cover` buildflag to enable coverage exporter. We don't need to
maintain main_test.go anymore.
```bash
➜ pwd
/home/fuwei/go/src/go.etcd.io/etcd/etcdctl
➜ go build -o /tmp/etcdctl -cover ./
➜ mkdir /tmp/etcdctl-covdata
➜ GOCOVERDIR=/tmp/etcdctl-covdata /tmp/etcdctl get /health
➜ go tool covdata percent -i=/tmp/etcdctl-covdata
go.etcd.io/etcd/etcdctl/v3 coverage: 66.7% of statements
go.etcd.io/etcd/etcdctl/v3/ctlv3 coverage: 83.3% of statements
go.etcd.io/etcd/etcdctl/v3/ctlv3/command coverage: 15.4% of statements
```
REF: https://go.dev/testing/coverage/
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2023-10-17 21:47:23 +08:00
aea1cd0077
feat: enable unparam lint
...
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2023-10-17 21:24:13 +08:00
7a57e06eca
etcdserver: add livez and ready http endpoints for etcd.
...
Add two separate probes, one for liveness and one for readiness. The liveness probe would check that the local individual node is up and running, or else restart the node, while the readiness probe would check that the cluster is ready to serve traffic. This would make etcd health-check fully Kubernetes API complient.
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2023-10-14 22:32:16 -07:00
867faa1924
etcdserver: remove redundant len check in health check
...
From the Go specification [1]:
"1. For a nil slice, the number of iterations is 0."
`len` returns 0 if the slice or map is nil [2]. Therefore, checking
`len(v) > 0` around a loop is unnecessary.
[1]: https://go.dev/ref/spec#For_range
[2]: https://pkg.go.dev/builtin#len
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com >
2023-10-13 18:39:38 +08:00
c25f1dff82
http health check bug fixes
...
Signed-off-by: Chao Chen <chaochn@amazon.com >
2023-10-12 16:59:34 -07:00
e4c0eb7712
bump google.golang.org/grpc to v1.58.3
...
Signed-off-by: Allen Ray <alray@redhat.com >
2023-10-11 10:39:05 -04:00
3a61187ce3
bump golang.org/x/net to v0.17.0
...
Address CVE-2023-39325 and CVE-2023-44487
Signed-off-by: Allen Ray <alray@redhat.com >
2023-10-11 10:09:14 -04:00
9f40116fa0
Return to default write scheduler since golang.org/x/net@v0.11.0 started using round robin
...
Introduction of round robin 120fc906b3https://github.com/golang/net/compare/v0.10.0...v0.11.0
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2023-10-10 16:31:42 +02:00
4540db9a7c
Merge pull request #16731 from sharathsivakumar/shsi/bump_dependencies_6
...
Bump dependencies generated by the bot manually
2023-10-10 13:51:48 +02:00
d884580432
dependency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.44.0 to 0.45.0
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com >
2023-10-10 11:50:54 +02:00
c94deb9511
dependency: bump github.com/prometheus/client_model from 0.4.1-0.20230718164431-9a2bf3000d16 to 0.5.0
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com >
2023-10-10 11:49:36 +02:00
1b1c42a7aa
dependency: bump golang.org/x/net from 0.15.0 to 0.16.0
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com >
2023-10-10 11:49:35 +02:00
16e19a9547
Merge pull request #16269 from dusk125/refactor-revision
...
Refactor common revision code to pkg
2023-10-10 10:16:58 +02:00
395376d3ab
Refactor common revision code to pkg
...
Signed-off-by: Allen Ray <alray@redhat.com >
2023-10-09 14:53:16 -04:00
c1fb2c2316
Use default embed config in e2e tests
...
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2023-10-05 14:17:45 +02:00
1c5289dd73
Merge pull request #16677 from serathius/revert-13525
...
Revert "etcd server shouldn't wait for the ready notification infinitely on startup"
2023-10-04 11:49:11 +02:00
074d79652d
depdendency: bump github.com/prometheus/client_golang from 1.16.0 to 1.17.0.
...
Signed-off-by: James Blair <mail@jamesblair.net >
2023-10-04 11:10:01 +13:00
aac8919b17
depdendency: bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.18.0 to 1.19.0.
...
Signed-off-by: James Blair <mail@jamesblair.net >
2023-10-04 11:06:38 +13:00
e31de5e3c1
Revert "etcd server shouldn't wait for the ready notification infinitely on startup"
...
This reverts commit 1713dc67b5siarkowicz@google.com >
2023-10-03 21:37:18 +02:00
50fb919318
Make AddEmbedFlags functon a method on embed.Config
...
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2023-10-02 13:53:38 +02:00
d98faeef82
Refactor registering flags to separate AddEmbedFlags function for future reuse
...
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2023-10-01 09:58:27 +02:00
70a3205506
fix broken unit test in server_test.go
...
Signed-off-by: Geeta Gharpure <geetagh@amazon.com >
2023-09-28 20:07:06 +01:00
9c9804399e
do not update RaftCluster.members and RaftCluster.removed if the v3store is ahead of the current replayed WAL entry index
...
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2023-09-28 20:06:12 +01:00
628b45c099
test: add a test case to verify consistent memberlist on bootstrap
...
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2023-09-28 20:04:47 +01:00
cfd35afe93
Merge pull request #16636 from ahrtr/grpc_20230925
...
dependency: bump some dependencies
2023-09-26 12:31:09 +01:00
4d486a2332
bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.17.0 to 1.18.0
...
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2023-09-25 21:00:55 +01:00
10cddaaf7c
bump go.opentelemetry.io/otel/sdk from 1.17.0 to 1.18.0
...
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2023-09-25 20:59:30 +01:00
df7f2d93f8
dependency: bump google.golang.org/grpc from 1.58.1 to 1.58.2
...
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2023-09-25 20:53:56 +01:00
4704a5af3a
*: fix unused issue
...
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2023-09-25 19:37:18 +08:00
