5e178e2288
mvcc/*_test.go: should not use duplicate revision.Main for one key
...
In commit [[1]], the newTestKeyIndex function creates one key with two
Revision{Main: 14} revisions. However, starting from version [[2]], etcd server
does not allow duplicate keys in a single transaction. This update to
newTestKeyIndex is to avoid confusion and ensure consistency with the
latest etcd server behavior.
REF:
[1]: be80d11948https://github.com/etcd-io/etcd/pull/4376
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2024-07-14 17:30:47 +08:00
5be397a6a8
Fix a linter issue
...
golangci-lint reports the following issue:
storage/mvcc/kvstore.go:312:27: (*store).restore - result 0 (error) is always nil (unparam)
It's due to the fact that both Attach() and compactLockfree() within the
function restore() are able to return an error, but we only log them in
the current implementation. Thus, the return value restore() is always
nil, hence the linter warning.
We have agreed to suppress the linter warning for now [1].
Reference:
[1] https://github.com/etcd-io/etcd/pull/18228#issuecomment-2187309957
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com >
2024-06-25 11:45:53 +02:00
c0076a788e
mvcc: fix typo
...
Signed-off-by: MR_G <2044783677@qq.com >
2024-06-22 00:17:13 +08:00
ea46253b42
Improve snapshot status
...
Signed-off-by: Cenk Alti <cenkalti@gmail.com >
2024-06-15 10:11:34 -04:00
45f14539e0
Merge pull request #18164 from andyxning/bugfix_register_of_walWriteSec
...
bugfix: register of walWriteSec
2024-06-14 18:32:15 +01:00
0b6529c462
mvcc: fix typo
...
Signed-off-by: lubronzhan <lubronzhan@gmail.com >
2024-06-13 00:15:37 -07:00
4a555fead3
bugfix: register of walWriteSec
...
Signed-off-by: Andy Xie <andy.xning@gmail.com >
2024-06-13 15:12:58 +08:00
b107d2437f
cli: Add etcdutl snapshot hashkv command
...
Signed-off-by: Cenk Alti <cenkalti@gmail.com >
Apply suggestions from code review
Co-authored-by: Benjamin Wang <benjamin.wang@broadcom.com >
2024-06-02 00:07:50 -04:00
09f7d7ab92
Merge pull request #17875 from ivanvc/fix-deprecation-comments-added-with-var-naming-lint-rule
...
Fix deprecation comments from addressing var-naming work
2024-04-30 19:51:37 +01:00
dafadd13c1
all: don't convert byte slice to string when using verb %s
...
This is unnecessary, as the documentation for 'go doc fmt' says:
%s the uninterpreted bytes of the string or slice
Signed-off-by: Jes Cok <xigua67damn@gmail.com >
2024-04-25 23:34:52 +08:00
242f5d60a8
Fix deprecation comments from addressing var-naming work
...
The deprecation tag/comment must to be followed by an empty line.
Signed-off-by: Ivan Valdes <ivan@vald.es >
2024-04-24 14:40:59 -07:00
94c83a962b
server/storage/mvcc: should update currentRev in revMu
...
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2024-04-24 11:08:33 +08:00
a2bf8d7e80
server/config: address golangci var-naming issues
...
Addresses issues in V2 Deprecation constant names.
Signed-off-by: Ivan Valdes <ivan@vald.es >
2024-04-22 17:12:15 -07:00
dd4e35a585
Merge pull request #17815 from fuweid/repro-17780
...
[RFC] fix revision loss issue caused by compaction - 17780
2024-04-22 18:15:44 +01:00
29529c505b
Merge pull request #17791 from ahrtr/verify_revision_bootstrap_20240415
...
Add verification that the revision shouldn't decrease on bootstrap
2024-04-22 10:43:01 +01:00
9ea234913a
server/storage: update currentRev if scheduledCompact > currentRev
...
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2024-04-21 18:12:38 +08:00
a54098dee3
Update the compaction log when bootstrap and update compact's signature
...
Actually the compact() never return an error, so remove the second return
parameter.
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com >
2024-04-15 14:16:18 +01:00
9ac964d1cc
Add verification that the revision shouldn't decrease on bootstrap
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com >
2024-04-15 13:56:19 +01:00
12fa1bb940
server/storage: change deprecated bolt error to new error package
...
Signed-off-by: idnandre <andre@idntimes.com >
2024-04-03 19:21:22 +07:00
cc32fa8559
Merge pull request #17618 from Akiqqqqqqq/feature-wal-write-metric
...
feat: add wal write system call metrics observation (main)
2024-03-31 16:54:20 +01:00
a25497e97d
Merge pull request #17660 from ivanvc/address-server-storage-var-naming-lint-rule
...
server/storage: address golangci var-naming issues
2024-03-29 10:02:25 +01:00
d43738a49b
server/storage: address golangci var-naming issues
...
Signed-off-by: Ivan Valdes <ivan@vald.es >
2024-03-27 10:12:42 -07:00
0a54362cca
add key dedupe when a write buffer writeback to an empty read buffer bucket.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2024-03-27 17:03:31 +00:00
7be3606841
Add tx buffer test case of unordered key writes.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2024-03-27 17:03:31 +00:00
4346a43cee
Add benchmark tests for buffer writeback function.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2024-03-27 17:03:26 +00:00
97efc2ade4
feat: observe wal write at one time
...
Signed-off-by: Qiuyu Wu <qiuyu.wu@shopee.com >
2024-03-26 17:26:02 +08:00
fbda591866
fix some typos
...
Signed-off-by: thirdkeyword <fliterdashen@gmail.com >
2024-03-25 10:34:44 +08:00
66f56d71e4
server: address golangci var-naming issues
...
Signed-off-by: Ivan Valdes <ivan@vald.es >
2024-03-20 21:12:12 -07:00
405862e807
Fix event loss after compaction
...
Signed-off-by: Chao Chen <chaochn@amazon.com >
2024-03-15 14:22:37 -07:00
fe113026fa
Increased timeout to fix HashKV test
...
Signed-off-by: Abhishek Kr Srivastav <Abhishek.kr.srivastav@ibm.com >
2024-02-23 15:58:57 +05:30
3565a822de
Add VerifyTxConsistency to backend.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
Update server/storage/backend/verify.go
Co-authored-by: Benjamin Wang <benjamin.wang@broadcom.com >
Update server/storage/backend/verify.go
Co-authored-by: Benjamin Wang <benjamin.wang@broadcom.com >
2024-02-22 11:31:16 -08:00
be28833212
etcdutl: Fix snapshot restore memory alloc issue
...
When running the snapshot command, allow receiving an initial memory map
allocation for the database, avoiding future memory allocation issues.
Co-authored-by: Benjamin Wang <benjamin.wang@broadcom.com >
Co-authored-by: Fatih USTA <fatihusta86@gmail.com >
Signed-off-by: Ivan Valdes <ivan@vald.es >
2024-02-13 13:36:13 -08:00
d69adf45f9
server: Implement WithMmapSize option for backend config
...
Accept a third argument for NewDefaultBackend for overrides to the
BackendConfig.
Add a new function, WithMmapSize, which modifies the backend config to
provide a custom InitiamMmapSize.
Signed-off-by: Ivan Valdes <ivan@vald.es >
2024-02-13 13:24:44 -08:00
c12e15d91a
Add verification on keys: should be always mononically increasing
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com >
2024-01-25 18:00:26 +00:00
c647614b6a
test: fix TestHashKVWhenCompacting: ensure all goroutine finished
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com >
2024-01-25 13:30:27 +00:00
dd0b0526e1
Merge pull request #17284 from ahrtr/test_TestScheduleCompaction_20240119
...
Fix test issue in TestScheduleCompaction
2024-01-20 13:29:04 +00:00
30b242f800
Revert "add test cases of duplicate keys in one tx."
...
This reverts commit 8d29b245a3sizhang@google.com >
2024-01-19 08:58:48 -08:00
93afd8e430
Revert "add key dedupe when a write buffer writeback to an empty read buffer bucket."
...
This reverts commit 971a4f57ccsizhang@google.com >
2024-01-19 08:58:27 -08:00
82562abc3c
Fix test issue in TestScheduleCompaction
...
It always reuse the same memory space. Each next iteration
will always overwrite previous data
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com >
2024-01-19 15:29:51 +00:00
690916f018
replace CreateBucket with CreateBucketIfNotExists
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com >
2024-01-16 09:40:20 +00:00
4bc55e5208
Merge pull request #17204 from rahulbapumore/branch1
...
mvcc: Printing etcd backend database related metrics inside scheduleCompaction function
2024-01-15 15:37:08 +00:00
21bbc82710
mvcc: Printing etcd backend database related metrics inside
...
scheduleCompaction function
To improve traceability of backend database usage, Added below parameter
related to backend database usage metrics inside scheduledCompaction
function.
current-db-size-bytes
current-db-size
current-db-size-in-use-bytes
current-db-size-in-use
Signed-off-by: Rahul More <rahulbapumore@gmail.com >
2024-01-15 17:36:38 +05:30
9ded10ec76
Merge pull request #17237 from ahrtr/bbolt_logger_20240112
...
Specify logger for bbolt
2024-01-13 11:03:14 +00:00
cfbf672b3c
specify logger for bbolt
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com >
2024-01-12 16:38:18 +00:00
971a4f57cc
add key dedupe when a write buffer writeback to an empty read buffer bucket.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2024-01-11 11:31:09 -08:00
8d29b245a3
add test cases of duplicate keys in one tx.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2024-01-11 11:31:03 -08:00
b3bf59a355
Merge pull request #17195 from siyuanfoundation/txBuf1
...
Fix delete inconsistencies in read buffer
2024-01-11 08:21:47 +00:00
db61c9695d
commit bbolt transaction if there is any pending deleting operations
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2024-01-10 09:33:21 -08:00
b3a5307640
add tests to test tx delete consistency.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2024-01-10 09:33:13 -08:00
d39d86a214
Improve logs around recovering from snapshot backend
...
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2023-12-20 16:26:27 +01:00
