647f1621d6
fix: enable gosimple linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-12-03 07:32:22 +01:00
c77ea65979
Reuse grpcOverheadBytes calculation by creating a function for that
...
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2024-12-02 19:04:38 +01:00
46127e7ea5
Merge pull request #18961 from ArkaSaha30/deps_mgmt_25_11_24
...
[2024-11-25] Manual Dependency Bump
2024-11-29 20:09:47 -07:00
6cebf973a1
Run a separate in memory snapshot to reduce number of entries stored in raft memory storage
...
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2024-11-29 20:40:02 +01:00
4cce12a724
Fix genproto annotations
...
* Please add etcd_version annotation in *.proto file with next etcd version
* Run ./scripts/genproto.sh
push_pin
* Run ./scripts/update_proto_annotations.sh
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com >
2024-11-29 16:39:53 +05:30
69efe31ea0
fix: enable gofumpt instead of gofmt linter in server
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-11-27 07:22:36 +01:00
86c6b5f2da
fix: enable usestdlibvars linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-11-07 10:28:48 +00:00
5858a08f1b
fix: enable require-error rule from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-31 08:33:34 +01:00
6883308899
Merge pull request #18800 from mmorel-35/testifylint/require-error
...
fix: enable require-error rule from testifylint in client, pkg and server packages
2024-10-30 23:03:01 +00:00
3a3115122e
fix: enable require-error rule from testifylint in client, pkg and server packages
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-28 21:02:58 +01:00
3abdf612b3
fix: enable errorlint in server directory
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-26 08:16:47 +02:00
6d2b23224c
Merge pull request #18739 from veshij/leak_fix
...
etcdserver: terminate recvLoop on serverWatchStream.close()
2024-10-24 11:29:43 +02:00
77607356d9
[serverWatchStream] terminate recvLoop on sws.close()
...
Signed-off-by: Oleg Guba <oleg.guba@gmail.com >
2024-10-21 12:09:27 -07:00
ff4a8df3aa
fix: enable formatter rule from testifylint
...
Signed-off-by: Thomas Gosteli <thomas.gosteli@protonmail.ch >
2024-10-17 14:10:35 +02:00
6165f60419
fix: enable expected-actual rule from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-17 09:17:59 +00:00
7ecb72a2b4
fix: enable error-nil rule from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-17 07:22:40 +02:00
f0187c38d1
Merge pull request #18689 from mmorel-35/testifylint/nil-compare
...
fix: enable nil-compare rule from testifylint
2024-10-11 09:41:28 +01:00
de2c95dcba
fix: enable nil-compare rule from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-11 07:10:03 +02:00
33d7f2d53e
fix: enable gofmt and whitespace linters
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-11 07:03:18 +02:00
e06fb81713
fix: enable empty and len rules from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-10 11:07:21 +00:00
b23947b604
fix: enable bool-compare rule from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-06 09:47:02 +02:00
d012386222
Merge pull request #18606 from monogon-dev/fix-islearner-panic
...
etcdserver: fix panic when checking IsLearner of removed member
2024-10-04 10:50:12 +01:00
c1976a6717
Merge pull request #18617 from redwrasse/redwrasse/server/remaining-errors-is
...
server: remaining errors.Is conversions
2024-10-03 14:47:01 +02:00
4284a71a6c
fix(v3compactor): flaky TestPeriodicSkipRevNotChange test by increasing timeout
...
Signed-off-by: Thomas Gosteli <thomas.gosteli@protonmail.ch >
2024-10-02 10:36:37 +00:00
3374e27f19
etcdserver: fix panic when checking IsLearner of removed member
...
There was a concurrency bug when accessing the IsLearner
property of a member, which will panic with a nil pointer access error
if the member is removed between the IsMemberExist() and Member() calls.
Signed-off-by: Jan Schär <jan@monogon.tech >
2024-09-30 11:13:23 +02:00
0739142ee3
server: errors.Is conversions
...
Signed-off-by: redwrasse <mail@redwrasse.io >
2024-09-29 05:23:47 -07:00
2f9532bfca
Merge pull request #18608 from srivastav-abhishek/periodic-compaction-flake-fix
...
Fixed periodic compaction tests
2024-09-22 09:17:13 +01:00
b8cb654be6
Use strict synchronization for revision getter to minimize flaky result caused by time racing.
...
Signed-off-by: Joshua Zhang <joshuazh@microsoft.com >
Addressed review comments
Co-authored-by: Abhishek Kr Srivastav <Abhishek.kr.srivastav@ibm.com >
Signed-off-by: Abhishek Kr Srivastav <Abhishek.kr.srivastav@ibm.com >
2024-09-19 17:34:24 +05:30
d4df7a902e
Replaces a number of error equality checks with errors.Is
...
Signed-off-by: redwrasse <mail@redwrasse.io >
2024-09-03 16:02:24 -07:00
bd228cf6d1
migrate experimental-stop-grpc-service-on-defrag flag to feature gate.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2024-08-05 13:46:51 -07:00
6a17ce3ff7
fix genproto after *.proto file update
...
Update genproto after *.proto change:
* Please rerun genproto.sh after changing *.proto file
* Run ./scripts/genproto.sh
Error encountered:
[0;31mFAIL: 'genproto' FAILED at Wed Jul 31 07:09:08 UTC 2024
make: *** [Makefile:134: verify-genproto] Error 255
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com >
2024-07-31 15:06:45 +05:30
9431e3a952
dependency: bump google.golang.org/grpc from 1.63.2 to 1.64.0
...
Reference:
- https://github.com/etcd-io/etcd/pull/18034
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com >
2024-05-20 22:45:14 +02:00
13c0f75b7d
Merge pull request #17877 from tjungblu/17872_status
...
add quota to endpoint status response
2024-05-03 13:03:23 +01:00
030066cdb2
Chore: Use chain interceptors from grpc package
...
Signed-off-by: Marcus Efraimsson <marcus.efraimsson@gmail.com >
2024-05-01 22:26:50 +02:00
09f7d7ab92
Merge pull request #17875 from ivanvc/fix-deprecation-comments-added-with-var-naming-lint-rule
...
Fix deprecation comments from addressing var-naming work
2024-04-30 19:51:37 +01:00
dafadd13c1
all: don't convert byte slice to string when using verb %s
...
This is unnecessary, as the documentation for 'go doc fmt' says:
%s the uninterpreted bytes of the string or slice
Signed-off-by: Jes Cok <xigua67damn@gmail.com >
2024-04-25 23:34:52 +08:00
bdcff246cb
add quota to endpoint status response
...
This adds the configured backend quota bytes to the endpoint status response.
related discussion in #17821
Signed-off-by: Thomas Jungblut <tjungblu@redhat.com >
2024-04-25 16:44:20 +02:00
242f5d60a8
Fix deprecation comments from addressing var-naming work
...
The deprecation tag/comment must to be followed by an empty line.
Signed-off-by: Ivan Valdes <ivan@vald.es >
2024-04-24 14:40:59 -07:00
379a8b79fb
fix version order when calling IsValidClusterVersionChange in UpdateCapability.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2024-04-23 09:31:19 -07:00
b6b7a1a3b6
refactor IsValidVersionChange.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2024-04-22 10:27:54 -07:00
bc31162cc2
all: call Close() after reading http.Response.Body
...
As the doc of http.Response.Body says:
// The http Client and Transport guarantee that Body is always
// non-nil, even on responses without a body or responses with
// a zero-length body. It is the caller's responsibility to
// close Body.
Signed-off-by: Jes Cok <xigua67damn@gmail.com >
2024-03-25 12:17:47 +08:00
97029d768a
Merge pull request #17614 from ivanvc/address-etcdserver-var-naming-lint-rule
...
etcdserver: address var naming lint rule
2024-03-19 22:40:03 +01:00
14523bdc21
etcdserver: rename MemberId() to MemberID() to address var-naming
...
Signed-off-by: Ivan Valdes <ivan@vald.es >
2024-03-18 17:18:29 -07:00
c613b78e6c
etcdserver: address golangci var-naming issues
...
Signed-off-by: Ivan Valdes <ivan@vald.es >
2024-03-18 17:17:07 -07:00
405862e807
Fix event loss after compaction
...
Signed-off-by: Chao Chen <chaochn@amazon.com >
2024-03-15 14:22:37 -07:00
6103504d4b
Fix progress notification for watch that doesn't get any events
...
When implementing the fix for progress notifications
(https://github.com/etcd-io/etcd/pull/15237 ) we made a incorrect
assumption that that unsynched watches will always get at least one event.
Unsynched watches include not only slow watchers, but also newly created
watches that requested current or older revision. In case that non of the events
match watch filter, those newly created watches might become synched
without any event going through.
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2024-03-11 12:11:09 +01:00
40f22e9319
Merge pull request #17176 from YaoC/fix-learner-metric
...
server: fix learner metric incorrect issue
2024-01-12 17:37:46 +01:00
f7ab7adf29
server: fix learner metric incorrect issue
...
Signed-off-by: YaoC <chengyao09@hotmail.com >
2024-01-12 09:36:33 +00:00
28f4c6fef6
dependency: bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.18.1 to 2.19.0
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com >
2024-01-09 16:26:47 +01:00
bc697bc26e
Revert "Switch to validating v3 when v2 and v3 are synchronized"
...
This reverts commit 4fe46f9203siarkowicz@google.com >
2023-12-03 18:12:09 +01:00
