mirrors/etcd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
20,873 Commits 124 Branches 418 Tags
b51a8346452a25b820434badbb4e00dcc7b5253f
Commit Graph

20873 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Stephen Kitt
1010115b8f server: switch to semconv v1.17.0 
This is the latest semconv package used in etcd's dependencies.
Switching to that version reduces the overall package dependencies of
the project (and helps downstream projects which track this,
e.g. Kubernetes).

Signed-off-by: Stephen Kitt <skitt@redhat.com>
 2023-07-24 15:53:04 +02:00
Benjamin Wang
d204487b6a Merge pull request #16283 from lance5890/fix_typo_in_raft.go 
update typo in raft.go
 2023-07-24 12:42:37 +01:00
lan.tian
0f975acf2f update typo in raft.go 
Signed-off-by: lan.tian <lance5890@163.com>
 2023-07-24 15:48:55 +08:00
Benjamin Wang
26b3ecf5aa Merge pull request #16281 from eltociear/fix-typo 
Fix typo in triage_issues.md
 2023-07-23 14:51:46 +01:00
Ikko Eltociear Ashimine
0a314c9da3 Fix typo in triage_issues.md 
Signed-off-by: Ikko Eltociear Ashimine <eltociear@gmail.com>
 2023-07-23 22:47:17 +09:00
Benjamin Wang
6979a06e6c Merge pull request #16257 from etcd-io/dependabot/go_modules/github.com/cheggaaa/pb/v3-3.1.4 
build(deps): bump github.com/cheggaaa/pb/v3 from 3.1.2 to 3.1.4
 2023-07-22 06:14:57 +01:00
Benjamin Wang
8d85baec80 dependency: bump github.com/cheggaaa/pb/v3 from 3.1.2 to 3.1.4 for etcdctl and tests 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2023-07-21 16:14:59 +01:00
dependabot[bot]
824337a272 build(deps): bump github.com/cheggaaa/pb/v3 from 3.1.2 to 3.1.4 
Bumps [github.com/cheggaaa/pb/v3](https://github.com/cheggaaa/pb) from 3.1.2 to 3.1.4.
- [Commits](https://github.com/cheggaaa/pb/compare/v3.1.2...v3.1.4)

---
updated-dependencies:
- dependency-name: github.com/cheggaaa/pb/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-07-21 16:12:27 +01:00
Benjamin Wang
d1ade07ab0 Merge pull request #16261 from etcd-io/dependabot/go_modules/tools/mod/github.com/mikefarah/yq/v4-4.34.2 
build(deps): bump github.com/mikefarah/yq/v4 from 4.34.1 to 4.34.2 in /tools/mod
 2023-07-21 15:58:51 +01:00
Benjamin Wang
cd453b931f Merge pull request #16271 from johnshajiang/cleanup-cluster 
tests: cleanup unnecessary assignment in cluster.go
 2023-07-20 08:16:36 +01:00
Benjamin Wang
92de641a22 Merge pull request #16268 from fuweid/fix-TestPageWriterRandom 
pkg/ioutil: deflake TestPageWriterRandom
 2023-07-19 16:07:47 +01:00
John Jiang
51a22c21ff tests: cleanup unnecessary assignment in cluster.go 
Signed-off-by: John Jiang <john.sha.jiang@gmail.com>
 2023-07-19 21:58:33 +08:00
Wei Fu
fddd1add52 pkg/ioutil: deflake TestPageWriterRandom 
The PageWriter has cache buffer so that it doesn't call the Writer until
the cache is almost full. Since the data's length is random, the pending
bytes should be always less than cache buffer size, instead of page
size.

Fix: #16255

Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-07-18 23:18:01 +08:00
Benjamin Wang
35628b9c78 Merge pull request #16230 from jmhbnz/align-arm64-commands 
Ensure release is run for arm64 e2e nightly tests
 2023-07-18 12:04:33 +01:00
James Blair
3ff0128842 Fix obtaining UPGRADE_VER in test.sh 
Obtain tags from git ls-remote to avoid reliance on local repository state.

Signed-off-by: James Blair <mail@jamesblair.net>
 2023-07-18 21:57:51 +12:00
Benjamin Wang
e209968dc3 Merge pull request #16263 from Rajalakshmi-Girish/flake-grpc-rr 
Fix flaky integration/clientv3/naming TestEtcdGrpcResolverRoundRobin
 2023-07-18 09:49:56 +01:00
Benjamin Wang
eb204f1d32 Merge pull request #16256 from gocurr/simplify_fmt_print 
etcdctl/ctlv3/command: simplify code using fmt.Printf with '\n'
 2023-07-18 09:47:36 +01:00
Benjamin Wang
7aad281317 Merge pull request #16252 from gocurr/avoid_hardcoding 
pkg/expect: avoid hardcoding when checking ErrProcessDone
 2023-07-18 09:47:03 +01:00
James Blair
2f65f56351 Ensure release is run for arm64 e2e nightly tests. 
Signed-off-by: James Blair <mail@jamesblair.net>
 2023-07-18 20:16:55 +12:00
zhangwenkang
c3e5201972 clientv3: fix barrier.Wait() still block after barrier.Release() in some cases 
Signed-off-by: Wenkang Zhang <314830391@qq.com>
 2023-07-18 15:48:48 +08:00
Wenkang Zhang
03d8fff0d8 clientv3: add Ctx() to return context of session 
Signed-off-by: Wenkang Zhang <314830391@qq.com>
 2023-07-18 15:22:53 +08:00
Rajalakshmi Girish
ea72194935 Fix flaky integration/clientv3/naming TestEtcdGrpcResolverRoundRobin 
Signed-off-by: Rajalakshmi Girish <rajalakshmi.girish1@ibm.com>
 2023-07-17 23:53:02 -07:00
Benjamin Wang
0c643dfb21 Merge pull request #16258 from etcd-io/dependabot/github_actions/github/codeql-action-2.20.4 
build(deps): bump github/codeql-action from 2.20.3 to 2.20.4
 2023-07-17 19:30:35 +01:00
dependabot[bot]
b71f335740 build(deps): bump github.com/mikefarah/yq/v4 in /tools/mod 
Bumps [github.com/mikefarah/yq/v4](https://github.com/mikefarah/yq) from 4.34.1 to 4.34.2.
- [Release notes](https://github.com/mikefarah/yq/releases)
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt)
- [Commits](https://github.com/mikefarah/yq/compare/v4.34.1...v4.34.2)

---
updated-dependencies:
- dependency-name: github.com/mikefarah/yq/v4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-07-17 17:40:07 +00:00
dependabot[bot]
91215fb1ca build(deps): bump github/codeql-action from 2.20.3 to 2.20.4 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.20.3 to 2.20.4.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](46ed16ded9...489225d82a)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-07-17 17:24:31 +00:00
Jes Cok
223a75b399 etcdctl/ctlv3/command: simplify code using fmt.Printf with '\n' 
The current printing code is complicated. This PR simplifies the
code and reduces the function calls.

Signed-off-by: Jes Cok <xigua67damn@gmail.com>
 2023-07-17 19:37:15 +08:00
Vitaly Zhuravlev
e282e6c111 Fix typo in mixin Makefile 
Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com>
 2023-07-17 09:32:59 +00:00
Benjamin Wang
bedd13298d Merge pull request #16251 from liangyuanpeng/changelog_backport_13577 
Add changelog for backport 13577 to 3.4&3.5.
 2023-07-17 08:25:25 +01:00
Marek Siarkowicz
11d22abe2b Merge pull request #16249 from iuriatan/update-linter 
Update linter and protoc
 2023-07-17 09:13:06 +02:00
Lan
6a9ea5ba6c Add changelog for backport 13577 to 3.4&3.5. 
Signed-off-by: Lan Liang <gcslyp@gmail.com>
 2023-07-17 13:39:15 +08:00
Jes Cok
5e65553d27 pkg/expect: avoid hardcoding when checking ErrProcessDone 
ExpectProcess's Stop method uses 'strings.Contains' to check
the returned err, however, this can be avoided. os.ErrProcessDone's
error message is the same as the hardcoded string. So I think
this explicit error is what this method wants to compare.

Signed-off-by: Jes Cok <xigua67damn@gmail.com>
 2023-07-17 13:14:15 +08:00
Benjamin Wang
ff411f517f Merge pull request #16224 from CaojiamingAlan/expose_isOptsWithFromKey_and_isOptsWithPrefix 
expose op.isOptsWithFromKey and op.isOptsWithPrefix
 2023-07-15 18:35:39 +01:00
caojiamingalan
bc97a94564 Follow up https://github.com/etcd-io/etcd/pull/16068#discussion_r1263664700 
Replace unnecessary Lock()/Unlock()s with RLock()/RUnlock()s

Signed-off-by: caojiamingalan <alan.c.19971111@gmail.com>
 2023-07-14 20:08:25 -05:00
Vitaly Zhuravlev
f5644361d0 Refactor monitroing mixin's dashboard 
Uses new grafonnet lib to declare dashboard. Generated dashboard has same layout, but now has timeseries panels instead of deprecated graphs

Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com>
 2023-07-15 00:16:51 +00:00
Vitaly Zhuravlev
a3bd22beef Add etcd_selector to dashboard queries 
Otherwise common metrics like 'process_resident_memory_bytes' can return non etcd metrics (when cluster label is 'cluster' for example)

Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com>
 2023-07-15 00:16:51 +00:00
Emily Ahlstrand Rager
f8d4b4ef91 Added lint config & alert summaries 
Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com>
 2023-07-15 00:16:51 +00:00
iuriatan
b424e60289 Update protoc from 3.14.0 to 3.20.3 
Signed-off-by: iuriatan <iuriatan@gmail.com>
 2023-07-14 16:46:26 -03:00
iuriatan
abbfc2964a Fix goword issue 
Fix `make verify` issues after updating golangci-lint

Signed-off-by: iuriatan <iuriatan@gmail.com>
 2023-07-14 16:46:26 -03:00
iuriatan
b798aae9c5 Update golangci-lint from 1.49.0 to 1.53.3 
Signed-off-by: iuriatan <iuriatan@gmail.com>
 2023-07-14 16:46:26 -03:00
Benjamin Wang
882edb3d63 Merge pull request #16231 from jmhbnz/robustness-arm64-release-35 
Add new job for nightly release35 arm64 robustness
 2023-07-14 14:56:38 +01:00
Benjamin Wang
c59bc52286 Merge pull request #16200 from kensou97/keepalive-ctx-closer 
clientv3: create keepAliveCtxCloser goroutine only if ctx can be canc…
 2023-07-14 13:46:15 +01:00
Benjamin Wang
dee90e19f1 Merge pull request #16229 from ahrtr/changelog_20230712 
Changelog: add items to cover the fix of bumping go to 1.19.11
 2023-07-14 12:08:07 +01:00
Marek Siarkowicz
2dc7891c7b Merge pull request #16234 from jmhbnz/add-new-reviewer 
Add jmhbnz as etcd reviewer
 2023-07-13 12:01:48 +02:00
Marek Siarkowicz
f008184b0e Merge pull request #16232 from cuishuang/main 
remove repetitive the
 2023-07-13 11:59:14 +02:00
James Blair
a35d24ab72 Add jmhbnz as etcd reviewer. 
Signed-off-by: James Blair <mail@jamesblair.net>
 2023-07-13 21:46:04 +12:00
cui fliter
6760dc9572 remove repetitive the 
Signed-off-by: cui fliter <imcusg@gmail.com>
 2023-07-13 17:01:01 +08:00
James Blair
5ffac59d88 Add new job for nightly release35 arm64 robustness. 
Signed-off-by: James Blair <mail@jamesblair.net>
 2023-07-13 20:58:16 +12:00
Benjamin Wang
1cf49e5ef0 Merge pull request #16173 from fuweid/fix-datarace-in-expect 
pkg/expect: fix data race
 2023-07-13 08:49:13 +01:00
Marek Siarkowicz
1ee6be793e Merge pull request #16226 from ahrtr/go_20230712 
Bump go version to 1.19.11 to fix CVE GO-2023-1878
 2023-07-13 09:30:57 +02:00
Wei Fu
56edfa6e28 pkg/expect: fix data race 
Let's say there is command which outputs one line and exit with error.

There are three goroutines to acquire the lock:

1. ep.read()
2. ep.waitSaveExitErr()
3. ep.Expect()

When ep.read goroutine reads the log but it doesn't acquire the lock in
time, the ep.waitSaveExitErr acquires the lock and updates the
`exitErr`. And then ep.Expect acquires lock but it doesn't see any log
yet and then returns err.

It's hard to reproduce it in local. Add the extra sleep can reproduce it.

```diff
diff --git a/pkg/expect/expect.go b/pkg/expect/expect.go
index a512a3ce4..602bea73f 100644
--- a/pkg/expect/expect.go
+++ b/pkg/expect/expect.go
@@ -128,6 +128,7 @@ func (ep *ExpectProcess) tryReadNextLine(r *bufio.Reader) error {
        printDebugLines := os.Getenv("EXPECT_DEBUG") != ""
        l, err := r.ReadString('\n')

+       time.Sleep(10 * time.Millisecond)
        ep.mu.Lock()
        defer ep.mu.Unlock()
```

See it once in Github Action [1]. In order to fix it, the patch introduces
`readCloseCh` to wait for ep.read to get all the data and retry it.

[1]: https://github.com/etcd-io/etcd/pull/16137#issuecomment-1605838518

Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-07-13 14:56:21 +08:00