aa97484166
*: enable goimports in verify-lint
...
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2023-09-21 21:14:09 +08:00
82243d0919
netutil: consistently format ipv6 addresses
...
This formats ipv6 addresses to ensure they can be compared safely
Signed-off-by: kidsan <8798449+Kidsan@users.noreply.github.com >
2023-01-31 06:50:42 +08:00
4d0b91947e
chore: delete // +build buildtag by go fix
...
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2022-12-29 14:17:05 +08:00
804fddf921
tests: Use zaptest.NewLogger in tests
2022-04-04 13:03:15 +02:00
63346bfead
server: Use default logging configuration instead of zap production one
...
This fixes problem where logs json changes format of timestamp.
2022-04-01 10:23:42 +02:00
b272b98b79
netutil: make a raw
URL comparison part of the urlsEqual function
2021-09-26 13:58:21 +07:00
eac75c28ae
Apply suggestions from code review
...
Co-authored-by: Lili Cosic <cosiclili@gmail.com >
2021-08-01 00:20:50 +07:00
b922a28622
netutil: add url comparison without resolver to URLStringsEqual
...
If one of the nodes in the cluster has lost a dns record,
restarting the second node will break it.
This PR makes an attempt to add a comparison without using a resolver,
which allows to protect cluster from dns errors and does not break
the current logic of comparing urls in the URLStringsEqual function.
You can read more in the issue #7798
Fixes #7798
2021-07-19 01:31:21 +07:00
3bb7acc8cf
Migrate dependencies pkg/foo -> client/pkg/foo
2021-04-07 00:38:47 +02:00
a7f340216d
Reformat code according to 'gotip' rules.
...
In practices adds annotations in the new syntax:
```
+//go:build !linux
// +build !linux
```
Fixes failing gotip PASSES='fmt' check:
https://travis-ci.com/github/etcd-io/etcd/jobs/486453806
2021-02-26 10:14:46 +01:00
85b61c0f4d
pkg/netutil: remove unused "iptables" wrapper
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com >
2020-11-25 10:38:42 -08:00
de55bb6331
pkg: Rename imports after making 'pkg' a module
...
find -name '*.go' | xargs sed --follow-symlinks -i 's|go.etcd.io/etcd/v3/pkg/|go.etcd.io/etcd/pkg/v3/|g'
go fmt ./...
2020-10-13 00:09:27 +02:00
96cce208c2
go.mod: use go.etcd.io/etcd/v3 versioning
...
This change makes the etcd package compatible with the existing Go
ecosystem for module versioning.
Used this tool to update package imports:
https://github.com/KSubedi/gomove
2020-04-28 00:57:35 +00:00
34bd797e67
*: revert module import paths
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com >
2019-05-28 15:39:35 -07:00
9150bf52d6
go modules: Fix module path version to include version number
2019-04-26 15:29:50 -07:00
d37f1521b7
*: update import paths to "go.etcd.io/etcd"
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com >
2018-08-28 17:47:55 -07:00
4baaf322fa
pkg/netutil: create doc.go
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com >
2018-04-27 11:41:50 -07:00
e8ba8feaed
pkg/netutil: use structured logging for TCP resolve
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com >
2018-04-27 11:40:13 -07:00
e1de74913d
pkg/netutil: return error from "URLStringsEqual"
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com >
2018-01-25 11:22:07 -08:00
75110dd839
*: fix naked returns
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com >
2017-11-10 18:46:15 -08:00
492bbc9659
netutil: test schemes for URLStringsEqual
...
add tests for http/https mismatch and unix scheme
2017-08-31 12:41:05 -07:00
6464574952
netutil: don't resolve unix socket URLs when comparing URLs
...
Was causing VerifyBootstrap() to hang on unix peers.
2017-08-17 19:58:24 -07:00
85e87e8f6b
netutil: use "context" and ctx-ize TCP addr resolution
2017-04-21 10:01:53 -07:00
88d4e7ebeb
netutil: fix unused err staticcheck failure
...
Clears SA4006
2017-04-07 10:52:54 -07:00
f97a077257
netutil: use ipv4 host by default
...
Was non-deterministic.
2017-02-21 20:11:35 -08:00
01a1dae7ae
pkg/netutil: name GetDefaultInterfaces consistent
2017-02-03 00:37:31 -08:00
0f53ad0b84
netutil: add dualstack to linux_route
...
in v3.1.0 netutil couldn't get default interface for ipv6only hosts
Fixes #7219
2017-01-31 22:19:47 +03:00
1ada4f939f
pkg/netutil: use native byte ordering for route information
...
Fixes #7199
2017-01-20 10:44:05 -08:00
13b05aeff8
netutil: ctx-ize URLStringsEqual
...
Handles the case where the DNS entry will only be set up after etcd
starts.
2016-12-14 15:46:30 -08:00
097cdbd0e4
pkg/netutil: get default interface for tc commands
...
Fix https://github.com/coreos/etcd/issues/6841 .
2016-11-17 22:49:17 -08:00
9473e9c30e
pkg: use etcd as logging repo
2016-09-29 15:29:38 +08:00
d23392ed8e
netutil: GetDefaultHost for getting the default IP of the host machine
2016-08-15 11:12:26 -07:00
8b77de4e99
pkg: update LICENSE header
2016-05-12 20:48:53 -07:00
6e6d64fb9b
*: clean up unused vars, functions
...
With help from https://github.com/dominikh/go-unused .
IsNetTimeoutError seems useful, so moved to pkg/netutil.
2016-04-06 21:33:55 -07:00
bd832e5b0a
*: migrate Godeps to vendor/
2016-03-22 17:10:28 -07:00
4422db389a
pkg/netutil: add linux netem functions
...
This is useful for simulating bad networks by introducing
latencies to wide area networks.
Reference:
http://www.linuxfoundation.org/collaborate/workgroups/networking/netem
2016-03-03 10:14:28 -08:00
81229dbea9
*: add missing package descriptions
...
This adds and updates package descriptions in etcd projects.
And also deletes some duplicate LICENSE statements.
2015-11-17 20:54:10 -08:00
e16f81838b
etcdhttp/auth: BasicAuth method in standard pkg
...
I created a new PR from https://github.com/coreos/etcd/pull/3598 .
This is for `TODO: use the standard lib BasicAuth method when we move to
Go 1.4.` [1]. `BasicAuth` method got into Go standard package a year ago. [2]
---
1. https://github.com/coreos/etcd/blob/master/pkg/netutil/netutil.go#L126-L138
2. https://codereview.appspot.com/76540043/
2015-09-28 14:02:55 -07:00
044b23c3ca
Merge pull request #3356 from xiang90/travis
...
*: test gofmt with -s and fix reported issues
2015-08-21 18:59:51 -07:00
6b23a8131f
*: test gofmt with -s and fix reported issues
2015-08-21 18:52:16 -07:00
3c1e6b54b3
pkg/netutil: stop resolving in place
...
It helps to copy out a and b, and not modify the original a and b.
2015-08-21 12:09:17 -07:00
1c334979cd
pkg/netutil: not introduce empty url when converting
...
It should not make slices with length and append elements at the same
time.
2015-08-21 12:08:17 -07:00
7b871aab41
pkg/netutil: not export resolve and urlsEqual functions
...
They are only used in this package, so there is no need to public them.
2015-08-21 11:58:37 -07:00
b1192e5c48
pkg/netutil: fix false negative comparison
...
Sort the resolved URLs before DeepEqual, so it will not compare URLs
that may be out of order due to resolution.
2015-08-21 10:15:08 -07:00
8ea3d157c5
Revert "Revert "Treat URLs have same IP address as same""
...
This reverts commit 3153e635d5
.
Conflicts:
etcdserver/config.go
2015-08-21 09:41:13 -07:00
8ad7ed321e
*:godep log pkg
2015-06-11 14:22:14 -07:00
a45f53986f
pkg/netutil: use leveled log
2015-06-11 14:19:52 -07:00
3153e635d5
Revert "Treat URLs have same IP address as same"
...
This reverts commit f8ce5996b0
.
etcd no longer resolves TCP addresses passed in through flags,
so there is no need to compare hostname and IP slices anymore.
(for more details: a3892221ee
)
Conflicts:
etcdserver/cluster.go
etcdserver/config.go
pkg/netutil/netutil.go
pkg/netutil/netutil_test.go
2015-05-16 03:21:10 -07:00
d9ad6aa2a9
*: update to use IANA-assigned ports
2015-04-06 13:49:43 -07:00
24f9ba8ee8
pkg/netutil: fix DropPort and RecoverPort in linux
...
The iptables commands in DropPort do not work because setting
destination-port flag without specifying the protocol is invalid.
2015-03-31 10:39:31 -07:00