mirrors/etcd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,892 Commits 124 Branches 418 Tags
e90504fe6211eca08472e71243513dc6e08b51fc
Commit Graph

16892 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Piotr Tabor
8ee1dd9e23 Merge pull request #12735 from ptabor/20210227-reduce-store-v2-clean 
no-store_v2:  Store ConfState as part of WAL log snapshot
 2021-03-25 08:23:00 +01:00
Piotr Tabor
4d4c84e014 server: Written Snapshot's to WAL contains populated ConfState. 
This will (among others) allow etcd-3.6 to not depend on store_v2 .snap files at all,
as WAL + db file will be self-sufficient.
 2021-03-25 00:31:44 +01:00
Piotr Tabor
fce0c192eb Regenerate protos. 2021-03-25 00:31:44 +01:00
Piotr Tabor
9180e8e56e wal: Update WAL Snapshot format to contain ConfState. 2021-03-25 00:31:44 +01:00
Piotr Tabor
65d6a1f4bf Merge pull request #12801 from ptabor/20210323-try-upgrade-proto 
Update dep: github.com/golang/protobuf v1.3.5 ->  v1.5.1, grpc: 1.32->1.36
 2021-03-24 23:57:56 +01:00
Piotr Tabor
d0962f10ae Adopt grpc_testing to grpc-1.36. 2021-03-24 23:31:03 +01:00
Piotr Tabor
a60676686b Update dep: grpc: 1.32.0 -> 1.36.0. 2021-03-24 22:27:55 +01:00
Piotr Tabor
45fb7b41d6 Update dep: github.com/golang/protobuf v1.3.5 ->  v1.5.1 
Thanks to https://go-review.googlesource.com/c/protobuf/+/300869/ its
feasible now.
 2021-03-24 22:27:12 +01:00
Piotr Tabor
7d7a9c6f23 codec.go: should use google runtime 
golang-proto runtime can deal with both: gogo & golang generated
protobufs. It does not work vice-versa with protobuf-1.5.1.
 2021-03-24 22:06:47 +01:00
Piotr Tabor
62d3eded87 test.sh: Temporarilly disable the "eeshew you" fmt check. 2021-03-24 20:40:13 +01:00
Piotr Tabor
1b300cd9e2 Merge pull request #12796 from joelsmith/master 
*: Update gogo/protobuf to v1.3.2, rerun ./scripts/genproto.sh
 2021-03-24 10:46:39 +01:00
Gyuho Lee
21188b5e0d Merge pull request #12798 from gyuho/security 
security: add private distributor list, and its application template
 2021-03-23 11:34:50 -07:00
Gyuho Lee
f18f609bcd security: add private distributor list, and its application template 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2021-03-23 11:34:15 -07:00
Joel Smith
19f7c6ef3e *: Update gogo/protobuf to v1.3.2, rerun ./scripts/genproto.sh 
While it appears that etcd is not vulnerable to CVE-2021-3121,
it is a good idea to update to the new generator so that new
vulnerable code isn't generated in any future APIs. Also, this
lays the issue to rest of whether there is any issue with
etcd and CVE-2021-3121.
 2021-03-23 11:48:06 -06:00
Piotr Tabor
4f34f14830 Merge pull request #12762 from wpedrak/postpone-read-index 
raft: postpone MsgReadIndex until first commit in the term
 2021-03-23 15:57:31 +01:00
Piotr Tabor
30ce6067da Merge pull request #12780 from wpedrak/read_index_retry 
Read index retry
 2021-03-23 13:47:41 +01:00
wpedrak
758ff0163c raft: postpone MsgReadIndex until first commit in the term 
Fixes #12680
 2021-03-23 12:28:42 +01:00
Piotr Tabor
456e129422 Merge pull request #12793 from gliptak/patch-1 
Correct ineffassign
 2021-03-23 09:19:26 +01:00
Gábor Lipták
49d19efd82 Correct ineffassign 2021-03-22 14:11:30 -04:00
Nathan VanBenschoten
e51c697ec6 raft: disable XXX_NoUnkeyedLiteral, XXX_unrecognized, and XXX_sizecache fields in protos 
This commit removes the `XXX_NoUnkeyedLiteral`, `XXX_unrecognized`, and
`XXX_sizecache` auto-generated fields from generated protobuf structs in
the raft package. This was done for all of the same reasons CockroachDB
removed the generation of these fields in https://github.com/cockroachdb/cockroach/pull/38404.
They come with very limited advantages but moderate disadvantages.

`XXX_NoUnkeyedLiteral` and `XXX_sizecache` were only enabled recently in
cc7b4fa, and this appears to have been unintentional. Meanwhile,
`XXX_unrecognized` has been around for longer and has arguably more
reason to stay because it can assist with forwards compatibility.
However, any real mixed-version upgrade story for this package is mostly
untold at this point, and keeping this field seems just as likely to
cause unexpected bugs (e.g. a field was propagated but not updated
correctly when passed through an old version) as it seems to fix real
issues, so it also doesn't warrant its cost.

This reduces the in-memory representation size of all Raft protos.
Notably, it reduces the memory size of an `Entry` proto from *80 bytes*
to *48 bytes* and the memory size of a `Message` proto from *392 bytes*
to *264 bytes*. Both of these structs are used frequently, and often in
slices, where this wasted space really starts to add up.

This was motivated by a regression in microbenchmarks in CockroachDB due
to cc7b4fa, which was caught in https://github.com/cockroachdb/cockroach/issues/62212.
 2021-03-20 03:24:18 -04:00
Nathan VanBenschoten
ebc01743df raft: Add TestProtoMemorySizes test 
This test checks the in-memory size of each proto struct to detect
unexpected changes to their memory representation.
 2021-03-20 03:23:57 -04:00
Piotr Tabor
8469108548 Merge pull request #12782 from ptabor/20210316-fixes 
Integration: Test flakiness fixes
 2021-03-19 20:10:11 +01:00
Piotr Tabor
18321a0c85 Merge pull request #12786 from ptabor/20210318-debug-env 
client: Bring back ETCD_CLIENT_DEBUG variable interpretation.
 2021-03-18 21:55:51 +01:00
Piotr Tabor
e2b5835e64 Fix go-tip: (1.17) fmt error: 
```
gofmt' started at Thu Mar 18 18:06:00 UTC 2021
transport/sockopt_unix.go
diff -u transport/sockopt_unix.go.orig transport/sockopt_unix.go
--- transport/sockopt_unix.go.orig	2021-03-18 18:06:01.667483834 +0000
+++ transport/sockopt_unix.go	2021-03-18 18:06:01.667483834 +0000
@@ -1,3 +1,4 @@
+//go:build !windows
 // +build !windows

 package transport
transport/sockopt_windows.go
diff -u transport/sockopt_windows.go.orig transport/sockopt_windows.go
--- transport/sockopt_windows.go.orig	2021-03-18 18:06:01.667483834 +0000
+++ transport/sockopt_windows.go	2021-03-18 18:06:01.667483834 +0000
@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
```
 2021-03-18 19:44:28 +01:00
Piotr Tabor
9312d1b077 clientv3: Bring back ETCD_CLIENT_DEBUG variable interpretation. 
env ETCD_CLIENT_DEBUG supports log levels (debug, info, warn, error, dpanic, panic, fatal).
Only when set, overrides application-wide grpc logging settings.
 2021-03-18 18:43:07 +01:00
Gyuho Lee
0a02a107ea Merge pull request #12787 from wpedrak/staticcheck_fixes 
*: over 20 staticcheck fixes
 2021-03-18 09:52:21 -07:00
wpedrak
dac6e37ea1 *: over 20 staticcheck fixes 2021-03-18 15:06:17 +01:00
Piotr Tabor
2932969b91 Merge pull request #12781 from ptabor/20210315-flaki-balancer 
Integration tests: Use testing.T logger through zap for grpc
 2021-03-18 08:30:54 +01:00
Piotr Tabor
63c51709b4 Merge pull request #12784 from ptabor/20210317-readme-go-version 
README: Update required go version.
 2021-03-17 15:41:21 +01:00
Piotr Tabor
7d53a06957 README: Update required go version. 2021-03-17 15:37:07 +01:00
Piotr Tabor
725a8c5e02 Enable configuring delegated zap-logging for embed server. 2021-03-17 08:17:36 +01:00
Piotr Tabor
6657d5907c Make sure all integration tests have BeforeTest. 
The CL disallows to create NewCluster in tests without BeforeTest.
 2021-03-16 23:50:01 +01:00
Piotr Tabor
809e7629ed Add integration.BeforeTest to all missing tests. 2021-03-16 23:50:01 +01:00
Piotr Tabor
a84bd093b0 Integration with grpc-settable logger. 2021-03-16 22:50:41 +01:00
Piotr Tabor
18382aa234 Fix 2 sources of leaked memory: embed server HTTP & v3_snapshot.leasser. 2021-03-16 22:20:00 +01:00
wpedrak
e9779231ec server: add 500ms retries to ReadIndex requests for l-reads 
It is second approach (with first being #12762) to solve #12680
 2021-03-16 16:34:15 +01:00
Piotr Tabor
a57e967d84 Integration test flakes fixes. 2021-03-16 16:08:18 +01:00
wpedrak
4b21e38381 refactored l-read loop in v3_server.go 2021-03-16 11:03:45 +01:00
Gyuho Lee
e599f4a482 Merge pull request #12775 from ptabor/20210314-zip 
etcd-raft-zap logger fixes.
 2021-03-14 11:37:11 -07:00
Piotr Tabor
1e7c1805d8 Unify logic of building raft-loggers for etcd. 
1. We had the same code copied 3 times.
2. For no good reason the code was not reusing existing logger if this one is given.
 2021-03-14 16:02:50 +01:00
Piotr Tabor
44bd22307e Merge get_logger() & Logger() method. 2021-03-14 14:05:17 +01:00
Piotr Tabor
527c765ece Merge pull request #12773 from ptabor/20210310-test-fixes 
Minor test fixes
 2021-03-14 13:36:19 +01:00
Piotr Tabor
de67806175 mend 2021-03-14 13:35:47 +01:00
Piotr Tabor
67491a00ea e2e/expect: In case of sut process failure, print last 40lines of logs. 2021-03-13 23:41:29 +01:00
Piotr Tabor
a47c18d30a Fix 2 remaining 'defer AfterTest' calls. 2021-03-13 23:41:29 +01:00
Piotr Tabor
0c1e6d05e7 Merge pull request #12772 from ptabor/20210312-3.5-todos 
Fix/remove broken: TestMetricDbSizeDefragDebugging
 2021-03-12 23:11:25 +01:00
Piotr Tabor
b406647dd7 Fix/remove broken: TestMetricDbSizeDefragDebugging 2021-03-12 23:05:53 +01:00
Gyuho Lee
efce58d1ec Merge pull request #12770 from ptabor/20210312-3.5-todos 
TODO's 3.5: Decommission metrics, PreVote=true.
 2021-03-12 08:51:21 -08:00
Piotr Tabor
948e32ae15 Delete etcd_debug metrics scheduled for deletion in 3.5. 2021-03-12 16:30:47 +01:00
Piotr Tabor
54189f2f60 Enable --pre-vote=true by default in 3.5. 2021-03-12 16:23:23 +01:00