a3650db574
use readTx in (*store).restore
2022-04-08 15:45:05 +08:00
1ea53d527e
server: Save consistency index and term to backend even when they decrease
...
Reason to store CI and term in backend was to make db fully independent
snapshot, it was never meant to interfere with apply logic. Skip of CI
was introduced for v2->v3 migration where we wanted to prevent it from
decreasing when replaying wal in
https://github.com/etcd-io/etcd/pull/5391 . By mistake it was added to
apply flow during refactor in
https://github.com/etcd-io/etcd/pull/12855#commitcomment-70713670 .
Consistency index and term should only be negotiated and used by raft to make
decisions. Their values should only driven by raft state machine and
backend should only be responsible for storing them.
2022-04-07 19:00:03 +02:00
4033f5c2b9
move the consistentIdx and consistentTerm from Etcdserver to cindex package
...
Removed the fields consistentIdx and consistentTerm from struct EtcdServer,
and added applyingIndex and applyingTerm into struct consistentIndex in
package cindex. We may remove the two fields completely if we decide to
remove the OnPreCommitUnsafe, and it will depend on the performance test
result.
2022-04-07 15:16:49 +08:00
e155e50886
rename LockWithoutHook to LockOutsideApply and add LockInsideApply
2022-04-07 05:35:13 +08:00
7ac995cdde
enhanced authBackend to support authReadTx
2022-04-07 05:35:13 +08:00
a4c5da844d
added detailed comment to explain the difference between Lock and LockWithoutHook
2022-04-07 05:35:13 +08:00
bfd5170f66
add a txPostLockHook into the backend
...
Previously the SetConsistentIndex() is called during the apply workflow,
but it's outside the db transaction. If a commit happens between SetConsistentIndex
and the following apply workflow, and etcd crashes for whatever reason right
after the commit, then etcd commits an incomplete transaction to db.
Eventually etcd runs into the data inconsistency issue.
In this commit, we move the SetConsistentIndex into a txPostLockHook, so
it will be executed inside the transaction lock.
2022-04-07 05:35:13 +08:00
ad03f2076a
Merge pull request #13886 from serathius/backend-logger
...
tests: Pass logger to backend
2022-04-05 16:35:07 +02:00
73fc864247
tests: Pass logger to backend
2022-04-05 15:53:38 +02:00
1d3517020b
server: Add verification of whether lock was called within out outside of apply
2022-04-05 15:34:45 +02:00
6c974a3e31
Merge pull request #13867 from serathius/logs-test
...
tests: Use zaptest.NewLogger in tests
2022-04-04 14:47:04 +02:00
804fddf921
tests: Use zaptest.NewLogger in tests
2022-04-04 13:03:15 +02:00
836bd6bc3a
fix WARNING: DATA RACE issue when multiple goroutines access the backend concurrently
2022-04-03 06:13:09 +08:00
9b3b383366
the file server/storage/mvcc/util.go isn't used at all, so removing it
2022-03-31 10:14:46 +08:00
3ecd8d2364
update incorrect migration log message
...
It can be upgrade or downgrade, so we should use word "updated" here.
2022-03-10 04:39:56 +08:00
d578a86a59
fix some log format typos
2022-03-10 03:26:34 +08:00
1ae5aa52de
fix some typos related to downgrade
2022-03-09 16:07:18 +08:00
124bc1ebbc
mvcc: clean up duplicate metrics name
2022-03-01 18:00:07 +08:00
0ecd4de923
delete duplicate metrics rangeCounterDebug
2022-02-28 16:22:40 +08:00
f80f477073
Merge pull request #13644 from Juneezee/refactor/t.TempDir
...
*: use `T.TempDir` to create temporary test directory
2022-02-21 19:52:37 +01:00
aa75fd0850
Merge pull request #13689 from AdamKorcz/fuzz7
...
server/storage/wal: fix oss-fuzz issue 44433
2022-02-14 15:48:55 -05:00
09e35a44ec
Merge pull request #13676 from chaochn47/fix_12535
...
Load all leases from backend
2022-02-14 21:32:33 +01:00
a0347261e4
Merge pull request #13679 from lavacat/defrag-bopts-fix
...
server/storage/backend: restore original bolt db options after defrag
2022-02-14 20:24:02 +01:00
0fcb2a628c
server/storage/wal: fix oss-fuzz issue 44433
2022-02-14 11:50:27 +00:00
fd79af9ee7
load all leases from backend
2022-02-13 20:30:20 -08:00
01347a8f53
server/storage/backend: restore original bolt db options after defrag
...
Problem: Defrag was implemented before custom bolt options were added.
Currently defrag doesn't restore backend options.
For example BackendFreelistType will be unset after defrag.
Solution: save bolt db options and use them in defrag.
2022-02-11 11:01:27 -08:00
029c354316
server/storage/mvcc: fix oss-fuzz issue 44449
2022-02-11 10:57:02 +00:00
f4187b4460
tools: Improve proto annotation documentation
2022-01-28 11:40:55 +01:00
4bfcd84259
server: Handle V2Request when analysis WAL entries
2022-01-26 15:50:14 +01:00
d865bb96f1
server: Refactor wal version to use visitor pattern
2022-01-26 15:50:14 +01:00
6d808e5d7d
*: Add static validation to etcd_version proto annotation
2022-01-26 15:50:14 +01:00
e9edc5432c
*: use T.TempDir to create temporary test directory
...
The directory created by `T.TempDir()` and is automatically removed when
the test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com >
2022-01-25 00:00:46 +08:00
17568a19f4
Merge pull request #13568 from horizonzy/avoid-always-put-metaterm
...
Avoid always update meta term.
2022-01-22 16:02:50 +01:00
282e4e6e88
make code more readable.
2022-01-19 22:24:49 +08:00
14a661e643
Merge pull request #13601 from lixd/op-put-lease
...
mvcc: add a fast return at put method
2022-01-19 14:47:26 +01:00
5b09de33a5
code clean: make rangeKeys close to storeTxnRead.
2022-01-17 11:12:25 +08:00
1d706179be
mvcc: add test-case
...
a test-case for new code-path.
2022-01-16 10:43:15 +08:00
0285f74aea
Merge pull request #13558 from gfuzz-asplos/main
...
fixing goroutine leaks
2022-01-15 16:58:19 +01:00
401cc1a575
mvcc: add a fast return at put method
...
return when two leaseID is equal, avoid invalid operations.
Fixes #13600
2022-01-15 13:16:44 +08:00
68fa5dcf99
Merge pull request #13549 from songlh-psu/main
...
fixing the goroutine leaks in TestHashKVWhenCompacting
2022-01-14 13:58:16 +01:00
a9652b4b4e
fixing the leaks in TestStressWatchCancelClose
2022-01-04 17:57:19 -05:00
0cc789d81d
update dump db tool
...
Signed-off-by: Liang Zheng <zhengliang0901@gmail.com >
2022-01-01 00:13:33 +08:00
97d1f935f6
avoid always update meta term.
2021-12-29 11:23:38 +08:00
98b0d901e8
fixing goroutine leaks
2021-12-24 15:57:38 -05:00
a45c73d9b1
resolve the conflict
2021-12-21 17:49:47 -05:00
69279532f4
Merge pull request #13540 from songlh-psu/fixing-3
...
fixing one panic and two goroutine leaks
2021-12-21 11:03:59 +01:00
246e7eba09
fixing the goroutine in two unit tests
2021-12-21 04:46:39 -05:00
5e8f50bb09
remove the extra stop
2021-12-17 20:03:19 -05:00
0098dbf350
fixing two goroutine leaks and one panic
2021-12-15 22:38:25 -05:00
3ebd0a7d00
fixing the goroutine leak in TestBackendClose
2021-12-15 01:54:51 -05:00
