mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hashmap: mark unused callback parameters

Browse Source 
Hashmap comparison functions must conform to a particular callback
interface, but many don't use all of their parameters. Especially the
void cmp_data pointer, but some do not use keydata either (because they
can easily form a full struct to pass when doing lookups). Let's mark
these to make -Wunused-parameter happy.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King
2022-08-19 06:08:46 -04:00
committed by Junio C Hamano
parent 783a86c142
commit 02c3c59e62
29 changed files with 59 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
sequencer.c
View File

@ -5254,7 +5254,8 @@ struct labels_entry {
char label[FLEX_ARRAY];
};
static int labels_cmp(const void *fndata, const struct hashmap_entry *eptr,
static int labels_cmp(const void *UNUSED(fndata),
const struct hashmap_entry *eptr,
const struct hashmap_entry *entry_or_key, const void *key)
{
const struct labels_entry *a, *b;
@ -6131,7 +6132,7 @@ struct subject2item_entry {
char subject[FLEX_ARRAY];
};
static int subject2item_cmp(const void *fndata,
static int subject2item_cmp(const void *UNUSED(fndata),
const struct hashmap_entry *eptr,
const struct hashmap_entry *entry_or_key,
const void *key)