mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

find_hook: keep our own static buffer

Browse Source 
The find_hook function returns the results of git_path,
which is a static buffer shared by other path-related calls.
Returning such a buffer is slightly dangerous, because it
can be overwritten by seemingly unrelated functions.

Let's at least keep our _own_ static buffer, so you can
only get in trouble by calling find_hook in quick
succession, which is less likely to happen and more obvious
to notice.

While we're at it, let's add some documentation of the
function's limitations.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King
2015-08-10 05:37:45 -04:00
committed by Junio C Hamano
parent 470e28d4e1
commit 03f2c7731b
2 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
run-command.c
View File

@ -797,11 +797,13 @@ int finish_async(struct async *async)
const char *find_hook(const char *name)
{
const char *path = git_path("hooks/%s", name);
if (access(path, X_OK) < 0)
path = NULL;
static struct strbuf path = STRBUF_INIT;
return path;
strbuf_reset(&path);
strbuf_git_path(&path, "hooks/%s", name);
if (access(path.buf, X_OK) < 0)
return NULL;
return path.buf;
}
int run_hook_ve(const char *const *env, const char *name, va_list args)