hashmap: add disallow_rehash setting
Teach hashmap to allow rehashes to be suppressed. This is useful when hashmaps are accessed by multiple threads. It still requires the caller to properly manage their locking. This just prevents unexpected rehashing during inserts and deletes. Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
f75619bd6d
commit
0607e10009
24
hashmap.h
24
hashmap.h
@ -39,6 +39,7 @@ struct hashmap {
|
||||
struct hashmap_entry **table;
|
||||
hashmap_cmp_fn cmpfn;
|
||||
unsigned int size, tablesize, grow_at, shrink_at;
|
||||
unsigned disallow_rehash : 1;
|
||||
};
|
||||
|
||||
struct hashmap_iter {
|
||||
@ -77,6 +78,29 @@ static inline void *hashmap_get_from_hash(const struct hashmap *map,
|
||||
return hashmap_get(map, &key, keydata);
|
||||
}
|
||||
|
||||
int hashmap_bucket(const struct hashmap *map, unsigned int hash);
|
||||
|
||||
/*
|
||||
* Disallow/allow rehashing of the hashmap.
|
||||
* This is useful if the caller knows that the hashmap
|
||||
* needs multi-threaded access. The caller is still
|
||||
* required to guard/lock searches and inserts in a
|
||||
* manner appropriate to their usage. This simply
|
||||
* prevents the table from being unexpectedly re-mapped.
|
||||
*
|
||||
* If is up to the caller to ensure that the hashmap is
|
||||
* initialized to a reasonable size to prevent poor
|
||||
* performance.
|
||||
*
|
||||
* When value=1, prevent future rehashes on adds and deleted.
|
||||
* When value=0, allow future rehahses. This DOES NOT force
|
||||
* a rehash now.
|
||||
*/
|
||||
static inline void hashmap_disallow_rehash(struct hashmap *map, unsigned value)
|
||||
{
|
||||
map->disallow_rehash = value;
|
||||
}
|
||||
|
||||
/* hashmap_iter functions */
|
||||
|
||||
extern void hashmap_iter_init(struct hashmap *map, struct hashmap_iter *iter);
|
||||
|
||||
Reference in New Issue
Block a user