Allow config file to specify Signed-off-by identity in format-patch.
Unlike git-commit, git-format-patch was not picking up and using the user.email config variable for the email part of the committer info. I was forced to use the GIT_COMMITTER_EMAIL environment variable to override the default <user@localhost.localdomain>. The fix was to simply move the call to setup_ident() to come before the git_config() call. Signed-off-by: Ramsay Allan Jones <ramsay@ramsay1.demon.co.uk> Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:

committed by
Junio C Hamano

parent
4e273c9dcf
commit
07efc6a6b6
@ -257,6 +257,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
|
|||||||
char message_id[1024];
|
char message_id[1024];
|
||||||
char ref_message_id[1024];
|
char ref_message_id[1024];
|
||||||
|
|
||||||
|
setup_ident();
|
||||||
git_config(git_format_config);
|
git_config(git_format_config);
|
||||||
init_revisions(&rev, prefix);
|
init_revisions(&rev, prefix);
|
||||||
rev.commit_format = CMIT_FMT_EMAIL;
|
rev.commit_format = CMIT_FMT_EMAIL;
|
||||||
@ -306,7 +307,6 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
|
|||||||
!strcmp(argv[i], "-s")) {
|
!strcmp(argv[i], "-s")) {
|
||||||
const char *committer;
|
const char *committer;
|
||||||
const char *endpos;
|
const char *endpos;
|
||||||
setup_ident();
|
|
||||||
committer = git_committer_info(1);
|
committer = git_committer_info(1);
|
||||||
endpos = strchr(committer, '>');
|
endpos = strchr(committer, '>');
|
||||||
if (!endpos)
|
if (!endpos)
|
||||||
|
Reference in New Issue
Block a user