mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "logmsg_reencode(): warn when iconv() fails"

Browse Source 
This reverts commit fd680bc5 (logmsg_reencode(): warn when iconv()
fails, 2021-08-27).  Throwing a warning for each and every commit
that gets reencoded, without allowing a way to squelch, would make
it unpleasant for folks who have to deal with an ancient part of the
history in an old project that used wrong encoding in the commits.
This commit is contained in:
Junio C Hamano
2021-10-29 13:48:58 -07:00
parent 1e93770888
commit 0988e665e9
3 changed files with 2 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pretty.c
View File

@ -671,11 +671,7 @@ const char *repo_logmsg_reencode(struct repository *r,
* If the re-encoding failed, out might be NULL here; in that
* case we just return the commit message verbatim.
*/
if (!out) {
warning("unable to reencode commit to '%s'", output_encoding);
return msg;
}
return out;
return out ? out : msg;
}
static int mailmap_name(const char **email, size_t *email_len,