t-reftable-record: add log tests for reftable_record_is_deletion()
reftable_record_is_deletion() is a function defined in
reftable/record.{c, h} that determines whether a record is of
type deletion or not. In the current testing setup, this function
is left untested for three of the four record types (log, obj, index).
Add tests for this function in the case of log records.
Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
Acked-by: Karthik Nayak <karthik.188@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
			
			
This commit is contained in:
		
				
					committed by
					
						
						Junio C Hamano
					
				
			
			
				
	
			
			
			
						parent
						
							aa3fef4ff3
						
					
				
				
					commit
					09ca34799b
				
			@ -220,6 +220,10 @@ static void t_reftable_log_record_roundtrip(void)
 | 
				
			|||||||
	set_hash(in[2].value.update.new_hash, 3);
 | 
						set_hash(in[2].value.update.new_hash, 3);
 | 
				
			||||||
	set_hash(in[2].value.update.old_hash, 4);
 | 
						set_hash(in[2].value.update.old_hash, 4);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
						check(!reftable_log_record_is_deletion(&in[0]));
 | 
				
			||||||
 | 
						check(reftable_log_record_is_deletion(&in[1]));
 | 
				
			||||||
 | 
						check(!reftable_log_record_is_deletion(&in[2]));
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	for (size_t i = 0; i < ARRAY_SIZE(in); i++) {
 | 
						for (size_t i = 0; i < ARRAY_SIZE(in); i++) {
 | 
				
			||||||
		struct reftable_record rec = { .type = BLOCK_TYPE_LOG };
 | 
							struct reftable_record rec = { .type = BLOCK_TYPE_LOG };
 | 
				
			||||||
		struct strbuf key = STRBUF_INIT;
 | 
							struct strbuf key = STRBUF_INIT;
 | 
				
			||||||
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user