mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

midx: fix broken free() in close_midx()

Browse Source 
When closing a multi-pack-index, we intend to close each pack-file
and free the struct packed_git that represents it. However, this
line was previously freeing the array of pointers, not the
pointer itself. This leads to a double-free issue.

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Derrick Stolee
2018-10-08 08:17:03 -07:00
committed by Junio C Hamano
parent f84b9b09d4
commit 0ce4ff9421
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
midx.c
View File

@ -190,7 +190,7 @@ static void close_midx(struct multi_pack_index *m)
for (i = 0; i < m->num_packs; i++) { for (i = 0; i < m->num_packs; i++) {
if (m->packs[i]) { if (m->packs[i]) {
close_pack(m->packs[i]); close_pack(m->packs[i]);
free(m->packs); free(m->packs[i]);
} }
} }
FREE_AND_NULL(m->packs); FREE_AND_NULL(m->packs);