index-pack: clarify the breached limit
As a small courtesy to users, report what limit was breached. This is especially useful when a push exceeds a server-defined limit, since the user is unlikely to have configured the limit (their host did). Also demonstrate the human-readable message in a test. Helped-by: Taylor Blau <me@ttaylorr.com> Helped-by: Derrick Stolee <derrickstolee@github.com> Signed-off-by: Matt Cooper <vtbassmatt@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
e6ebfd0e8c
commit
0cf5fbc2e4
@ -284,4 +284,12 @@ test_expect_success 'index-pack -v --stdin produces progress for both phases' '
|
||||
test_i18ngrep "Resolving deltas" err
|
||||
'
|
||||
|
||||
test_expect_success 'too-large packs report the breach' '
|
||||
pack=$(git pack-objects --all pack </dev/null) &&
|
||||
sz="$(test_file_size pack-$pack.pack)" &&
|
||||
test "$sz" -gt 20 &&
|
||||
test_must_fail git index-pack --max-input-size=20 pack-$pack.pack 2>err &&
|
||||
grep "maximum allowed size (20 bytes)" err
|
||||
'
|
||||
|
||||
test_done
|
||||
|
Reference in New Issue
Block a user