mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-gui: Cache all repo-config data in an array.

Browse Source 
We're likely going to need key/value pairs from the repo-config beyond
just remote.*.url, so cache them all up front into a Tcl array where we
have fast access to them without needing to refork a repo-config --list
process.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
This commit is contained in:
Shawn O. Pearce
2006-11-07 04:26:02 -05:00
parent 37af79d10d
commit 0d4f3eb5f3
1 changed files with 19 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
git-gui
View File

@ -791,8 +791,23 @@ proc toggle_mode {path} {
## ##
## config (fetch push pull) ## config (fetch push pull)
proc load_repo_config {} {
global repo_config
array unset repo_config
catch {
set fd_rc [open "| git repo-config --list" r]
while {[gets $fd_rc line] >= 0} {
if {[regexp {^([^=]+)=(.*)$} $line line name value]} {
lappend repo_config($name) $value
}
}
close $fd_rc
}
}
proc load_all_remotes {} { proc load_all_remotes {} {
global gitdir all_remotes global gitdir all_remotes repo_config
set all_remotes [list] set all_remotes [list]
set rm_dir [file join $gitdir remotes] set rm_dir [file join $gitdir remotes]
@ -804,13 +819,11 @@ proc load_all_remotes {} {
-directory $rm_dir *]] -directory $rm_dir *]]
} }
set fd_rc [open "| git repo-config --list" r] foreach line [array names repo_config remote.*.url] {
while {[gets $fd_rc line] >= 0} { if {[regexp ^remote\.(.*)\.url\$ $line line name]} {
if {[regexp ^remote\.(.*)\.url= $line line name]} {
lappend all_remotes $name lappend all_remotes $name
} }
} }
close $fd_rc
set all_remotes [lsort -unique $all_remotes] set all_remotes [lsort -unique $all_remotes]
} }
@ -1541,6 +1554,7 @@ if {$appname == {git-citool}} {
wm title . "$appname ([file normalize [file dirname $gitdir]])" wm title . "$appname ([file normalize [file dirname $gitdir]])"
focus -force $ui_comm focus -force $ui_comm
load_repo_config
load_all_remotes load_all_remotes
populate_remote_menu .mbar.fetch From fetch_from populate_remote_menu .mbar.fetch From fetch_from
populate_remote_menu .mbar.push To push_to populate_remote_menu .mbar.push To push_to