vscode: only overwrite C/C++ settings
The C/C++ settings are special, as they are the only generated VS Code configurations that *will* change over the course of Git's development, e.g. when a new constant is defined. Therefore, let's only update the C/C++ settings, also to prevent user modifications from being overwritten. Ideally, we would keep user modifications in the C/C++ settings, but that would require parsing JSON, a task for which a Unix shell script is distinctly unsuited. So we write out .new files instead, and warn the user if they may want to reconcile their changes. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
b4d991d1a2
commit
0f47f78e02
@ -13,7 +13,7 @@ die "Could not create .vscode/"
|
|||||||
|
|
||||||
# General settings
|
# General settings
|
||||||
|
|
||||||
cat >.vscode/settings.json <<\EOF ||
|
cat >.vscode/settings.json.new <<\EOF ||
|
||||||
{
|
{
|
||||||
"C_Cpp.intelliSenseEngine": "Default",
|
"C_Cpp.intelliSenseEngine": "Default",
|
||||||
"C_Cpp.intelliSenseEngineFallback": "Disabled",
|
"C_Cpp.intelliSenseEngineFallback": "Disabled",
|
||||||
@ -51,7 +51,7 @@ esac
|
|||||||
|
|
||||||
# Default build task
|
# Default build task
|
||||||
|
|
||||||
cat >.vscode/tasks.json <<EOF ||
|
cat >.vscode/tasks.json.new <<EOF ||
|
||||||
{
|
{
|
||||||
// See https://go.microsoft.com/fwlink/?LinkId=733558
|
// See https://go.microsoft.com/fwlink/?LinkId=733558
|
||||||
// for the documentation about the tasks.json format
|
// for the documentation about the tasks.json format
|
||||||
@ -73,7 +73,7 @@ die "Could not install default build task"
|
|||||||
|
|
||||||
# Debugger settings
|
# Debugger settings
|
||||||
|
|
||||||
cat >.vscode/launch.json <<EOF ||
|
cat >.vscode/launch.json.new <<EOF ||
|
||||||
{
|
{
|
||||||
// Use IntelliSense to learn about possible attributes.
|
// Use IntelliSense to learn about possible attributes.
|
||||||
// Hover to view descriptions of existing attributes.
|
// Hover to view descriptions of existing attributes.
|
||||||
@ -175,3 +175,20 @@ vscode-init:
|
|||||||
echo '}'
|
echo '}'
|
||||||
EOF
|
EOF
|
||||||
die "Could not write settings for the C/C++ extension"
|
die "Could not write settings for the C/C++ extension"
|
||||||
|
|
||||||
|
for file in .vscode/settings.json .vscode/tasks.json .vscode/launch.json
|
||||||
|
do
|
||||||
|
if test -f $file
|
||||||
|
then
|
||||||
|
if git diff --no-index --quiet --exit-code $file $file.new
|
||||||
|
then
|
||||||
|
rm $file.new
|
||||||
|
else
|
||||||
|
printf "The file $file.new has these changes:\n\n"
|
||||||
|
git --no-pager diff --no-index $file $file.new
|
||||||
|
printf "\n\nMaybe \`mv $file.new $file\`?\n\n"
|
||||||
|
fi
|
||||||
|
else
|
||||||
|
mv $file.new $file
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
Reference in New Issue
Block a user