fetch_pack(): drop unused parameters

We don't need the caller of fetch_pack() to pass in "dest", which is the
remote URL. Since ba227857d2 (Reduce the number of connects when
fetching, 2008-02-04), the caller is responsible for calling
git_connect() itself, and our "dest" parameter is unused.

That commit also started passing us the resulting "conn" child_process
from git_connect(). But likewise, we do not need do anything with it.
The descriptors in "fd" are enough for us, and the caller is responsible
for cleaning up "conn".

We can just drop both parameters.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King
2019-03-20 04:16:14 -04:00
committed by Junio C Hamano
parent c5c33504c9
commit 0f804b0bac
4 changed files with 7 additions and 11 deletions

View File

@ -78,9 +78,8 @@ struct fetch_pack_args {
* marked as such.
*/
struct ref *fetch_pack(struct fetch_pack_args *args,
int fd[], struct child_process *conn,
int fd[],
const struct ref *ref,
const char *dest,
struct ref **sought,
int nr_sought,
struct oid_array *shallow,