Clean up object creation to use more common code
This replaces the fairly odd "created_object()" function that did _most_ of the object setup with a more complete "create_object()" function that also has a more natural calling convention. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:

committed by
Junio C Hamano

parent
2c1cbec1e2
commit
100c5f3b0b
10
tag.c
10
tag.c
@ -20,13 +20,9 @@ struct object *deref_tag(struct object *o, const char *warn, int warnlen)
|
||||
|
||||
struct tag *lookup_tag(const unsigned char *sha1)
|
||||
{
|
||||
struct object *obj = lookup_object(sha1);
|
||||
if (!obj) {
|
||||
struct tag *ret = alloc_tag_node();
|
||||
created_object(sha1, &ret->object);
|
||||
ret->object.type = OBJ_TAG;
|
||||
return ret;
|
||||
}
|
||||
struct object *obj = lookup_object(sha1);
|
||||
if (!obj)
|
||||
return create_object(sha1, OBJ_TAG, alloc_tag_node());
|
||||
if (!obj->type)
|
||||
obj->type = OBJ_TAG;
|
||||
if (obj->type != OBJ_TAG) {
|
||||
|
Reference in New Issue
Block a user