mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cache: use const char * for get_object_directory()

Browse Source 
The get_object_directory() method returns the exact string stored at
the_repository->objects->odb->path. The return type of "char *" implies
that the caller must keep track of the buffer and free() it when
complete. This causes significant problems later when the ODB is
accessed.

Use "const char *" as the return type to avoid this confusion. There are
no current callers that care about the non-const definition.

Signed-off-by: Derrick Stolee <derrickstolee@github.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Derrick Stolee
2022-04-25 18:27:14 +00:00
committed by Junio C Hamano
parent b56166ca57
commit 11f9e8de3d
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cache.h
View File

@ -567,7 +567,7 @@ extern char *git_work_tree_cfg;
int is_inside_work_tree(void); int is_inside_work_tree(void);
const char *get_git_dir(void); const char *get_git_dir(void);
const char *get_git_common_dir(void); const char *get_git_common_dir(void);
char *get_object_directory(void); const char *get_object_directory(void);
char *get_index_file(void); char *get_index_file(void);
char *get_graft_file(struct repository *r); char *get_graft_file(struct repository *r);
void set_git_dir(const char *path, int make_realpath); void set_git_dir(const char *path, int make_realpath);

2
environment.c
View File

@ -271,7 +271,7 @@ const char *get_git_work_tree(void)
return the_repository->worktree; return the_repository->worktree;
} }
char *get_object_directory(void) const char *get_object_directory(void)
{ {
if (!the_repository->objects->odb) if (!the_repository->objects->odb)
BUG("git environment hasn't been setup"); BUG("git environment hasn't been setup");