mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t/helper: mark unused argv/argc arguments

Browse Source 
Many test helper programs do not bother to look at argc or argv, because
they don't take any options. In a user-facing program, it's a good idea
to check for unexpected arguments and complain. But for a test helper,
it's not worth the trouble to enforce this.

But we do want to tell the compiler we're OK with ignoring them, to
silence -Wunused-parameter (and obviously we can't get rid of them,
since we have to conform to the usual cmd__foo() interface).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King
2023-03-28 16:57:25 -04:00
committed by Junio C Hamano
parent 6ba21fa65c
commit 126e3b3d2a
27 changed files with 33 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
t/helper/test-trace2.c
View File

@ -208,7 +208,7 @@ static int ut_007BUG(int argc, const char **argv)
BUG("the bug message");
}
static int ut_008bug(int argc, const char **argv)
static int ut_008bug(int argc UNUSED, const char **argv UNUSED)
{
bug("a bug message");
bug("another bug message");
@ -216,7 +216,7 @@ static int ut_008bug(int argc, const char **argv)
return 0;
}
static int ut_009bug_BUG(int argc, const char **argv)
static int ut_009bug_BUG(int argc UNUSED, const char **argv UNUSED)
{
bug("a bug message");
bug("another bug message");
@ -224,7 +224,7 @@ static int ut_009bug_BUG(int argc, const char **argv)
return 0;
}
static int ut_010bug_BUG(int argc, const char **argv)
static int ut_010bug_BUG(int argc UNUSED, const char **argv UNUSED)
{
bug("a %s message", "bug");
BUG("a %s message", "BUG");