symbolic-ref -d: do not allow removal of HEAD
If you delete the symbolic-ref HEAD from a repository, Git no longer
considers the repository valid, and even "git symbolic-ref HEAD
refs/heads/master" would not be able to recover from that state
(although "git init" can, but that is a sure sign that you are
talking about a "broken" repository).
In the spirit similar to afe5d3d5
("symbolic ref: refuse non-ref
targets in HEAD", 2009-01-29), forbid removal of HEAD to avoid
corrupting a repository.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
@ -33,18 +33,25 @@ test_expect_success 'symbolic-ref refuses bare sha1' '
|
||||
'
|
||||
reset_to_sane
|
||||
|
||||
test_expect_success 'symbolic-ref deletes HEAD' '
|
||||
git symbolic-ref -d HEAD &&
|
||||
test_expect_success 'HEAD cannot be removed' '
|
||||
test_must_fail git symbolic-ref -d HEAD
|
||||
'
|
||||
|
||||
reset_to_sane
|
||||
|
||||
test_expect_success 'symbolic-ref can be deleted' '
|
||||
git symbolic-ref NOTHEAD refs/heads/foo &&
|
||||
git symbolic-ref -d NOTHEAD &&
|
||||
test_path_is_file .git/refs/heads/foo &&
|
||||
test_path_is_missing .git/HEAD
|
||||
test_path_is_missing .git/NOTHEAD
|
||||
'
|
||||
reset_to_sane
|
||||
|
||||
test_expect_success 'symbolic-ref deletes dangling HEAD' '
|
||||
git symbolic-ref HEAD refs/heads/missing &&
|
||||
git symbolic-ref -d HEAD &&
|
||||
test_expect_success 'symbolic-ref can delete dangling symref' '
|
||||
git symbolic-ref NOTHEAD refs/heads/missing &&
|
||||
git symbolic-ref -d NOTHEAD &&
|
||||
test_path_is_missing .git/refs/heads/missing &&
|
||||
test_path_is_missing .git/HEAD
|
||||
test_path_is_missing .git/NOTHEAD
|
||||
'
|
||||
reset_to_sane
|
||||
|
||||
|
Reference in New Issue
Block a user