mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PATCH] Fix memory leaks in git-fsck-cache

Browse Source 
This patch fixes memory leaks in parse_object() and related functions;
these leaks were very noticeable when running git-fsck-cache.

Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Sergey Vlasov
2005-05-04 21:44:15 +04:00
committed by Linus Torvalds
parent 705acc5c94
commit 13019d4136
5 changed files with 27 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tree.c
View File

@ -101,9 +101,11 @@ int parse_tree(struct tree *item)
if (!buffer)
return error("Could not read %s",
sha1_to_hex(item->object.sha1));
if (strcmp(type, tree_type))
if (strcmp(type, tree_type)) {
free(buffer);
return error("Object %s not a tree",
sha1_to_hex(item->object.sha1));
}
list_p = &item->entries;
while (size) {
struct object *obj;
@ -113,8 +115,10 @@ int parse_tree(struct tree *item)
char *path = strchr(bufptr, ' ');
unsigned int mode;
if (size < len + 20 || !path ||
sscanf(bufptr, "%o", &mode) != 1)
sscanf(bufptr, "%o", &mode) != 1) {
free(buffer);
return -1;
}
entry = xmalloc(sizeof(struct tree_entry_list));
entry->name = strdup(path + 1);
@ -138,5 +142,6 @@ int parse_tree(struct tree *item)
*list_p = entry;
list_p = &entry->next;
}
free(buffer);
return 0;
}