mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t5305: move cleanup into test block

Browse Source 
We usually try to avoid doing any significant actions
outside of test blocks. Although "rm -rf" is unlikely to
either fail or to generate output, moving these to the
point of use makes it more clear that they are part of the
overall setup of "clone.git".

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King
2016-09-05 17:52:10 -04:00
committed by Junio C Hamano
parent e0c1ceafc5
commit 1962d9fbe3
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
t/t5305-include-tag.sh
View File

@ -25,7 +25,6 @@ test_expect_success setup '
} >obj-list } >obj-list
' '
rm -rf clone.git
test_expect_success 'pack without --include-tag' ' test_expect_success 'pack without --include-tag' '
packname_1=$(git pack-objects \ packname_1=$(git pack-objects \
--window=0 \ --window=0 \
@ -33,6 +32,7 @@ test_expect_success 'pack without --include-tag' '
' '
test_expect_success 'unpack objects' ' test_expect_success 'unpack objects' '
rm -rf clone.git &&
( (
GIT_DIR=clone.git && GIT_DIR=clone.git &&
export GIT_DIR && export GIT_DIR &&
@ -51,7 +51,6 @@ test_expect_success 'check unpacked result (have commit, no tag)' '
test_cmp list.expect list.actual test_cmp list.expect list.actual
' '
rm -rf clone.git
test_expect_success 'pack with --include-tag' ' test_expect_success 'pack with --include-tag' '
packname_1=$(git pack-objects \ packname_1=$(git pack-objects \
--window=0 \ --window=0 \
@ -60,6 +59,7 @@ test_expect_success 'pack with --include-tag' '
' '
test_expect_success 'unpack objects' ' test_expect_success 'unpack objects' '
rm -rf clone.git &&
( (
GIT_DIR=clone.git && GIT_DIR=clone.git &&
export GIT_DIR && export GIT_DIR &&