builtin/show-ref: ensure mutual exclusiveness of subcommands
The git-show-ref(1) command has three different modes, of which one is implicit and the other two can be chosen explicitly by passing a flag. But while these modes are standalone and cause us to execute completely separate code paths, we gladly accept the case where a user asks for both `--exclude-existing` and `--verify` at the same time even though it is not obvious what will happen. Spoiler: we ignore `--verify` and execute the `--exclude-existing` mode. Let's explicitly detect this invalid usage and die in case both modes were requested. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
ee26f1e29a
commit
199970e72f
@ -196,4 +196,13 @@ test_expect_success 'show-ref --verify with dangling ref' '
|
||||
)
|
||||
'
|
||||
|
||||
test_expect_success 'show-ref sub-modes are mutually exclusive' '
|
||||
cat >expect <<-EOF &&
|
||||
fatal: only one of ${SQ}--exclude-existing${SQ} or ${SQ}--verify${SQ} can be given
|
||||
EOF
|
||||
|
||||
test_must_fail git show-ref --verify --exclude-existing 2>err &&
|
||||
test_cmp expect err
|
||||
'
|
||||
|
||||
test_done
|
||||
|
Reference in New Issue
Block a user