bisect: fix "git bisect skip <commit>" and add tests cases

The patch that allows "git bisect skip" to be passed a range of
commits using the "<commit1>..<commit2>" notation is flawed because
it introduces a regression when it was passed a simple rev or commit.

"git bisect skip <commit>" doesn't work any more, because <commit>
is quoted but not properly unquoted.

This patch fixes that and add tests cases to better check when it is
passed commits and range of commits.

While at it, this patch also properly quotes the non range arguments
using the "sq" function.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
This commit is contained in:
Christian Couder
2008-12-02 14:53:47 +01:00
committed by Junio C Hamano
parent ff3c0ff20e
commit 1a66a489d0
2 changed files with 20 additions and 3 deletions

View File

@ -199,11 +199,11 @@ bisect_skip() {
*..*)
revs=$(git rev-list "$arg") || die "Bad rev input: $arg" ;;
*)
revs="'$arg'" ;;
revs=$(sq "$arg") ;;
esac
all="$all $revs"
done
bisect_state 'skip' $all
eval bisect_state 'skip' $all
}
bisect_state() {