mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

commit: avoid parent list buildup in clear_commit_marks_many()

Browse Source 
clear_commit_marks_1() clears the marks of the first parent and its
first parent and so on, and saves the higher numbered parents in a list
for later.  There is no benefit in keeping that list growing with each
handled commit.  Clear it after each run to reduce peak memory usage.

Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
René Scharfe
2025-02-23 09:26:04 +01:00
committed by Junio C Hamano
parent 2d2a71ce85
commit 1ca727f230
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
commit.c
View File

@ -780,14 +780,14 @@ static void clear_commit_marks_1(struct commit_list **plist,
void clear_commit_marks_many(size_t nr, struct commit **commit, unsigned int mark) void clear_commit_marks_many(size_t nr, struct commit **commit, unsigned int mark)
{ {
for (size_t i = 0; i < nr; i++) {
struct commit_list *list = NULL; struct commit_list *list = NULL;
for (size_t i = 0; i < nr; i++) {
clear_commit_marks_1(&list, *commit, mark); clear_commit_marks_1(&list, *commit, mark);
commit++;
}
while (list) while (list)
clear_commit_marks_1(&list, pop_commit(&list), mark); clear_commit_marks_1(&list, pop_commit(&list), mark);
commit++;
}
} }
void clear_commit_marks(struct commit *commit, unsigned int mark) void clear_commit_marks(struct commit *commit, unsigned int mark)