mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

receive-pack: release the linked "struct command *" list

Browse Source 
Fix a memory leak that's been with us since this code was introduced
in [1]. Later in [2] we started using FLEX_ALLOC_MEM() to allocate the
"struct command *".

1. 575f497456 (Add first cut at "git-receive-pack", 2005-06-29)
2. eb1af2df0b (git-receive-pack: start parsing ref update commands,
   2005-06-29)

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason
2023-02-07 00:07:52 +01:00
committed by Junio C Hamano
parent fb2ebe72a3
commit 1fdd31cf52
10 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
builtin/receive-pack.c
View File

@ -2032,6 +2032,16 @@ static struct command **queue_command(struct command **tail,
return &cmd->next;
}
static void free_commands(struct command *commands)
{
while (commands) {
struct command *next = commands->next;
free(commands);
commands = next;
}
}
static void queue_commands_from_cert(struct command **tail,
struct strbuf *push_cert)
{
@ -2569,6 +2579,7 @@ int cmd_receive_pack(int argc, const char **argv, const char *prefix)
run_receive_hook(commands, "post-receive", 1,
&push_options);
run_update_post_hook(commands);
free_commands(commands);
string_list_clear(&push_options, 0);
if (auto_gc) {
struct child_process proc = CHILD_PROCESS_INIT;