mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

am, sequencer: stop parsing our own committer ident

Browse Source 
For the --committer-date-is-author-date option of git-am and git-rebase,
we format the committer ident, then re-parse it to find the name and
email, and then feed those back to fmt_ident().

We can simplify this by handling it all at the time of the fmt_ident()
call. We pass in the appropriate getenv() results, and if they're not
present, then our WANT_COMMITTER_IDENT flag tells fmt_ident() to fill in
the appropriate value from the config. Which is exactly what
git_committer_ident() was doing under the hood.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King
2020-10-23 03:26:30 -04:00
committed by Junio C Hamano
parent 5f35edd9d7
commit 2020451c5b
3 changed files with 5 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
sequencer.h
View File

@ -50,8 +50,6 @@ struct replay_opts {
int mainline;
char *committer_name;
char *committer_email;
char *gpg_sign;
enum commit_msg_cleanup_mode default_msg_cleanup;
int explicit_cleanup;