Clean up pthread_create() error handling
Normally pthread_create() rarely fails. But with new pthreads wrapper, pthread_create() will return ENOSYS on a system without thread support. Threaded code _is_ protected by HAVE_THREADS and pthread_create() should never run in the first place. But the situation could change in the future and bugs may sneak in. Make sure that all pthread_create() reports the error cause. While at there, mark these strings for translation if they aren't. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
f5c4a9af45
commit
2179045fd0
@ -1213,7 +1213,7 @@ int start_async(struct async *async)
|
||||
{
|
||||
int err = pthread_create(&async->tid, NULL, run_thread, async);
|
||||
if (err) {
|
||||
error_errno("cannot create thread");
|
||||
error(_("cannot create async thread: %s"), strerror(err));
|
||||
goto error;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user