mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sha1_file: use the correct type (ssize_t, not size_t) for read-style function

Browse Source 
Using an unsigned type, we would fail to detect a read error and then
proceed to try to write (size_t)-1 bytes.

Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jim Meyering
2011-05-26 16:34:20 +02:00
committed by Junio C Hamano
parent 93aa7bd595
commit 23c7df6bdd
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
sha1_file.c
View File

@ -2733,7 +2733,7 @@ static int index_stream(unsigned char *sha1, int fd, size_t size,
while (size) { while (size) {
char buf[10240]; char buf[10240];
size_t sz = size < sizeof(buf) ? size : sizeof(buf); size_t sz = size < sizeof(buf) ? size : sizeof(buf);
size_t actual; ssize_t actual;
actual = read_in_full(fd, buf, sz); actual = read_in_full(fd, buf, sz);
if (actual < 0) if (actual < 0)