From 24d7ce383a3d92feae6a641499448fde43206fd8 Mon Sep 17 00:00:00 2001 From: Phillip Wood Date: Tue, 22 Feb 2022 18:53:32 +0000 Subject: [PATCH] terminal: always reset terminal when reading without echo Break out of the loop to ensure restore_term() is called before returning. Signed-off-by: Phillip Wood Signed-off-by: Junio C Hamano --- compat/terminal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/terminal.c b/compat/terminal.c index 5b903e7c7e..fb8c70a625 100644 --- a/compat/terminal.c +++ b/compat/terminal.c @@ -385,7 +385,7 @@ int read_key_without_echo(struct strbuf *buf) ch = getchar(); if (ch == EOF) - return 0; + break; strbuf_addch(buf, ch); } }