Update callers of check_ref_format()
This updates send-pack and fast-import to use symbolic constants for checking the return values from check_ref_format(), and also futureproof the logic in lock_any_ref_for_update() to explicitly name the case that is usually considered an error but is Ok for this particular use. Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
6
refs.c
6
refs.c
@ -822,10 +822,10 @@ struct ref_lock *lock_ref_sha1(const char *ref, const unsigned char *old_sha1)
|
||||
struct ref_lock *lock_any_ref_for_update(const char *ref, const unsigned char *old_sha1, int flags)
|
||||
{
|
||||
switch (check_ref_format(ref)) {
|
||||
case CHECK_REF_FORMAT_ERROR:
|
||||
case CHECK_REF_FORMAT_WILDCARD:
|
||||
return NULL;
|
||||
default:
|
||||
return NULL;
|
||||
case 0:
|
||||
case CHECK_REF_FORMAT_ONELEVEL:
|
||||
return lock_ref_sha1_basic(ref, old_sha1, flags, NULL);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user