strbuf: accept a comment string for strbuf_stripspace()
As part of our transition to multi-byte comment characters, let's take a NUL-terminated string pointer for strbuf_stripspace(), rather than a single character. We can continue to support its feature of ignoring comments by accepting a NULL pointer (as opposed to the current behavior of a NUL byte). All of the callers have to be adjusted, but they can all just pass comment_line_str (or NULL). Inside the function we detect comments by comparing the first byte of a line to the comment character. We'll adjust that to use starts_with(), which will match multiple bytes (though for now, of course, we still only allow a single byte, so it's academic). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
72a7d5d97f
commit
2982b65690
@ -890,7 +890,7 @@ static int prepare_to_commit(const char *index_file, const char *prefix,
|
||||
s->hints = 0;
|
||||
|
||||
if (clean_message_contents)
|
||||
strbuf_stripspace(&sb, '\0');
|
||||
strbuf_stripspace(&sb, NULL);
|
||||
|
||||
if (signoff)
|
||||
append_signoff(&sb, ignored_log_message_bytes(sb.buf, sb.len), 0);
|
||||
|
Reference in New Issue
Block a user