Fix a copy-n-paste bug in the object decorator code.
Duh. When I did the object decorator thing, I made the "loop over the hash" function use the same logic for updating the hash, ie made them use if (++j >= size) j = 0; for both the hash update for both "insert" and "lookup" HOWEVER. For some inexplicable reason I had an extraneous j++; in the insert path (probably just from the fact that the old code there used j++; if (j >= size) j = 0; and when I made them use the same logic I just didn't remove the old extraneous line properly. This fixes it. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
		
				
					committed by
					
						
						Junio C Hamano
					
				
			
			
				
	
			
			
			
						parent
						
							2c9750cc8b
						
					
				
				
					commit
					2a1a3dce33
				
			@ -24,7 +24,6 @@ static void *insert_decoration(struct decoration *n, struct object *base, void *
 | 
			
		||||
			hash[j].decoration = decoration;
 | 
			
		||||
			return old;
 | 
			
		||||
		}
 | 
			
		||||
		j++;
 | 
			
		||||
		if (++j >= size)
 | 
			
		||||
			j = 0;
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
		Reference in New Issue
	
	Block a user