mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

revert: fix off by one read when searching the end of a commit subject

Browse Source 
A test case is added but the problem can only be seen when running
the test case with --valgrind.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Acked-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Christian Couder
2010-07-22 15:18:29 +02:00
committed by Junio C Hamano
parent 971ecbd1f8
commit 2c048a3038
2 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
builtin/revert.c
View File

@ -127,7 +127,7 @@ static int get_message(const char *raw_message, struct commit_message *out)
p++;
if (*p) {
p += 2;
for (eol = p + 1; *eol && *eol != '\n'; eol++)
for (eol = p; *eol && *eol != '\n'; eol++)
; /* do nothing */
} else
eol = p;