mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PATCH] diff: fix the culling of unneeded delete record.

Browse Source 
The commit 15d061b435

    [PATCH] Fix the way diffcore-rename records unremoved source.

still leaves unneeded delete records in its output stream by
mistake, which was covered up by having an extra check to turn
such a delete into a no-op downstream.  Fix the check in the
diffcore-rename to simplify the output routine.

Signed-off-by: Junio C Hamano <junkio@cox.net>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Junio C Hamano
2005-05-30 00:08:07 -07:00
committed by Linus Torvalds
parent 9d429ff6ff
commit 2cd68882ee
2 changed files with 35 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
diff.c
View File

@ -792,27 +792,8 @@ static void diff_resolve_rename_copy(void)
p->status = 'U';
else if (!DIFF_FILE_VALID(p->one))
p->status = 'N';
else if (!DIFF_FILE_VALID(p->two)) {
/* Deleted entry may have been picked up by
* another rename-copy entry. So we scan the
* queue and if we find one that uses us as the
* source we do not say delete for this entry.
*/
for (j = 0; j < q->nr; j++) {
pp = q->queue[j];
if (!strcmp(p->one->path, pp->one->path) &&
DIFF_PAIR_RENAME(pp)) {
/* rename/copy are always valid
* so we do not say DIFF_FILE_VALID()
* on pp->one and pp->two.
*/
p->status = 'X';
break;
}
}
if (!p->status)
p->status = 'D';
}
else if (!DIFF_FILE_VALID(p->two))
p->status = 'D';
else if (DIFF_PAIR_TYPE_CHANGED(p))
p->status = 'T';