test output: respect $TEST_OUTPUT_DIRECTORY
Most test results go in $TEST_OUTPUT_DIRECTORY, but the output files for tests run with --tee or --valgrind just use bare "test-results". Changes these so that they do respect $TEST_OUTPUT_DIRECTORY. As a result of this, the valgrind/analyze.sh script may no longer inspect the correct files so it is also updated to respect $TEST_OUTPUT_DIRECTORY by adding it to GIT-BUILD-OPTIONS. This may be a regression for people who have TEST_OUTPUT_DIRECTORY in their config.mak but want to override it in the environment, but this change merely brings it into line with GIT_TEST_OPTS which already cannot be overridden if it is specified in config.mak. Signed-off-by: John Keeping <john@keeping.me.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
54bb9015c8
commit
2d14e13c56
@ -1,6 +1,10 @@
|
||||
#!/bin/sh
|
||||
|
||||
out_prefix=$(dirname "$0")/../test-results/valgrind.out
|
||||
# Get TEST_OUTPUT_DIRECTORY from GIT-BUILD-OPTIONS if it's there...
|
||||
. "$(dirname "$0")/../../GIT-BUILD-OPTIONS"
|
||||
# ... otherwise set it to the default value.
|
||||
: ${TEST_OUTPUT_DIRECTORY=$(dirname "$0")/..}
|
||||
|
||||
output=
|
||||
count=0
|
||||
total_count=0
|
||||
@ -115,7 +119,7 @@ handle_one () {
|
||||
finish_output
|
||||
}
|
||||
|
||||
for test_script in "$(dirname "$0")"/../test-results/*.out
|
||||
for test_script in "$TEST_OUTPUT_DIRECTORY"/test-results/*.out
|
||||
do
|
||||
handle_one $test_script
|
||||
done
|
||||
|
Reference in New Issue
Block a user