notes: refactor display notes extra refs field
There's no need to use an extra pointer, which just ends up leaking memory. The fact that the list is empty tells us the same thing. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
c063f0a973
commit
304cc11c65
4
notes.c
4
notes.c
@ -1066,9 +1066,9 @@ void init_display_notes(struct display_notes_opt *opt)
|
||||
|
||||
git_config(notes_display_config, &load_config_refs);
|
||||
|
||||
if (opt && opt->extra_notes_refs) {
|
||||
if (opt) {
|
||||
struct string_list_item *item;
|
||||
for_each_string_list_item(item, opt->extra_notes_refs)
|
||||
for_each_string_list_item(item, &opt->extra_notes_refs)
|
||||
string_list_add_refs_by_glob(&display_notes_refs,
|
||||
item->string);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user