From 317c1762798f9e1ee0cb8096a2071561a8bb1fdc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Date: Tue, 5 Jan 2021 20:42:36 +0100 Subject: [PATCH] mktag tests: don't redirect stderr to a file needlessly MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove the redirection of stderr to "message" in the valid tag test. This pattern seems to have been copy/pasted from the failure case in 446c6faec6 (New tests and en-passant modifications to mktag., 2006-07-29). While I'm at it do the same for the "replace" tests. The tag creation I'm changing here seems to have been copy/pasted from the "mktag" tests to those tests in cc400f50112 (mktag: call "check_sha1_signature" with the replacement sha1, 2009-01-23). Nobody examines the contents of the resulting "message" file, so the net result is that error messages cannot be seen in "sh t3800-mktag.sh -v" output. Signed-off-by: Ævar Arnfjörð Bjarmason Signed-off-by: Junio C Hamano --- t/t3800-mktag.sh | 4 ++-- t/t6050-replace.sh | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t3800-mktag.sh b/t/t3800-mktag.sh index e1a2892f58..c542c3e1a8 100755 --- a/t/t3800-mktag.sh +++ b/t/t3800-mktag.sh @@ -222,7 +222,7 @@ EOF test_expect_success \ 'allow empty tag email' \ - 'git mktag .git/refs/tags/mytag 2>message' + 'git mktag .git/refs/tags/mytag' ############################################################ # 16. disallow spaces in tag email @@ -350,7 +350,7 @@ EOF test_expect_success \ 'create valid tag' \ - 'git mktag .git/refs/tags/mytag 2>message' + 'git mktag .git/refs/tags/mytag' ############################################################ # 25. check mytag diff --git a/t/t6050-replace.sh b/t/t6050-replace.sh index c80dc10b8f..0dbe086118 100755 --- a/t/t6050-replace.sh +++ b/t/t6050-replace.sh @@ -129,7 +129,7 @@ tagger T A Gger <> 0 +0000 EOF test_expect_success 'tag replaced commit' ' - git mktag .git/refs/tags/mytag 2>message + git mktag .git/refs/tags/mytag ' test_expect_success '"git fsck" works' '