mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

shortlog: warn the user when there is no input

Browse Source 
A simple "git shortlog" outside of a git repository stalls
waiting for an input. Check if that's the case by testing with
isatty() before read_from_stdin(), and warn the user like
"git commit" does in a similar case.

Signed-off-by: Michele Ballabio <barra_cuda@katamail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Michele Ballabio
2010-02-24 21:49:03 +01:00
committed by Junio C Hamano
parent e923eaeb90
commit 3731449591
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
builtin-shortlog.c
View File

@ -295,6 +295,8 @@ parse_done:
if (!nongit && !rev.pending.nr && isatty(0)) if (!nongit && !rev.pending.nr && isatty(0))
add_head_to_pending(&rev); add_head_to_pending(&rev);
if (rev.pending.nr == 0) { if (rev.pending.nr == 0) {
if (isatty(0))
fprintf(stderr, "(reading log message from standard input)\n");
read_from_stdin(&log); read_from_stdin(&log);
} }
else else