mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Win32: unify environment case-sensitivity

Browse Source 
The environment on Windows is case-insensitive. Some environment functions
(such as unsetenv and make_augmented_environ) have always used case-
sensitive comparisons instead, while others (getenv, putenv, sorting in
spawn*) were case-insensitive.

Prevent potential inconsistencies by using case-insensitive comparison in
lookup_env (used by putenv, unsetenv and make_augmented_environ).

Signed-off-by: Karsten Blees <blees@dcon.de>
Signed-off-by: Stepan Kasal <kasal@ucw.cz>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Karsten Blees
2014-07-17 17:37:58 +02:00
committed by Junio C Hamano
parent e96942e821
commit 38d2750126
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
compat/mingw.c
View File

@ -1199,8 +1199,7 @@ static int lookup_env(char **env, const char *name, size_t nmln)
int i; int i;
for (i = 0; env[i]; i++) { for (i = 0; env[i]; i++) {
if (0 == strncmp(env[i], name, nmln) if (!strncasecmp(env[i], name, nmln) && '=' == env[i][nmln])
&& '=' == env[i][nmln])
/* matches */ /* matches */
return i; return i;
} }