check return code of prepare_revision_walk
A failure in prepare_revision_walk can be caused by a not parseable object. Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
24e8a3c946
commit
3d51e1b5b8
@ -197,7 +197,8 @@ static int cmd_log_walk(struct rev_info *rev)
|
||||
if (rev->early_output)
|
||||
setup_early_output(rev);
|
||||
|
||||
prepare_revision_walk(rev);
|
||||
if (prepare_revision_walk(rev))
|
||||
die("revision walk setup failed");
|
||||
|
||||
if (rev->early_output)
|
||||
finish_early_output(rev);
|
||||
@ -556,7 +557,8 @@ static void get_patch_ids(struct rev_info *rev, struct patch_ids *ids, const cha
|
||||
o2->flags ^= UNINTERESTING;
|
||||
add_pending_object(&check_rev, o1, "o1");
|
||||
add_pending_object(&check_rev, o2, "o2");
|
||||
prepare_revision_walk(&check_rev);
|
||||
if (prepare_revision_walk(&check_rev))
|
||||
die("revision walk setup failed");
|
||||
|
||||
while ((commit = get_revision(&check_rev)) != NULL) {
|
||||
/* ignore merges */
|
||||
@ -781,7 +783,8 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
|
||||
if (!use_stdout)
|
||||
realstdout = xfdopen(xdup(1), "w");
|
||||
|
||||
prepare_revision_walk(&rev);
|
||||
if (prepare_revision_walk(&rev))
|
||||
die("revision walk setup failed");
|
||||
while ((commit = get_revision(&rev)) != NULL) {
|
||||
/* ignore merges */
|
||||
if (commit->parents && commit->parents->next)
|
||||
@ -923,7 +926,8 @@ int cmd_cherry(int argc, const char **argv, const char *prefix)
|
||||
die("Unknown commit %s", limit);
|
||||
|
||||
/* reverse the list of commits */
|
||||
prepare_revision_walk(&revs);
|
||||
if (prepare_revision_walk(&revs))
|
||||
die("revision walk setup failed");
|
||||
while ((commit = get_revision(&revs)) != NULL) {
|
||||
/* ignore merges */
|
||||
if (commit->parents && commit->parents->next)
|
||||
|
Reference in New Issue
Block a user